migrate destinations to use airbyte protocol #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michel-tricot
approved these changes
Oct 14, 2020
|
|
||
| public class Instants { | ||
|
|
||
| public static long millisToSeconds(long millis) { |
There was a problem hiding this comment.
You can call it toSeconds as long as the argument is called millis.
jrhizor
approved these changes
Oct 14, 2020
|
|
||
| public class Instants { | ||
|
|
||
| public static long toSeconds(long millis) { |
There was a problem hiding this comment.
Is this necessary when long seconds = TimeUnit.MILLISECONDS.toSeconds(millis); is part of the standard library?
cgardens
force-pushed
the
cgardens/migrate_destinationst_airbyte_protocol
branch
from
b9fb9c7 to
aee8806
Compare
cgardens
force-pushed
the
cgardens/migrate_destinationst_airbyte_protocol
branch
from
6d7fa94 to
8dc0d07
Compare
This was referenced Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly just find/replace type of operations.