-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Destination BigQueryDenormalized : fixed stackoverflow and array type parsing when source forget to send "items" details for it #5813
Conversation
…o handle case when received schema doesn't contain a data type for Array type
/test connector=connectors/destination-bigquery-denormalized
|
/test connector=connectors/destination-bigquery-denormalized
|
This PR should fix issues: 5529, 5472, 5486, 4778 issues |
/test connector=connectors/destination-bigquery-denormalized
|
/publish connector=connectors/destination-bigquery-denormalized
|
What
Sometimes source connectors may send a Schema for Array without a mandatory "items" block. At the current implementation, we are not able to assemble find schema and fail with StackOverflow.
How
This PR introduces a handler for it, to avoid a crash. But anyway we will also need to create a ticket for source connects to make them fix on their side as well (python part).
This PR should fix issues: 5529, 5472, 5486, 4778 issues
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
docs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes