Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Destination BigQueryDenormalized : fixed stackoverflow and array type parsing when source forget to send "items" details for it #5813

Merged

Conversation

etsybaev
Copy link
Contributor

@etsybaev etsybaev commented Sep 2, 2021

What

Sometimes source connectors may send a Schema for Array without a mandatory "items" block. At the current implementation, we are not able to assemble find schema and fail with StackOverflow.

How

This PR introduces a handler for it, to avoid a crash. But anyway we will also need to create a ticket for source connects to make them fix on their side as well (python part).
This PR should fix issues: 5529, 5472, 5486, 4778 issues

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

…o handle case when received schema doesn't contain a data type for Array type
@etsybaev
Copy link
Contributor Author

etsybaev commented Sep 3, 2021

/test connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1197891761
✅ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1197891761

@jrhizor jrhizor temporarily deployed to more-secrets September 3, 2021 12:01 Inactive
@etsybaev
Copy link
Contributor Author

etsybaev commented Sep 3, 2021

Since all tests passed, i'm bumping version as well
Selection_049

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Sep 3, 2021
@etsybaev etsybaev changed the title [Draft_PR]Fixed (stuckoverflow) destination bigquery denormalized destination t… 🐛 Destination BigQueryDenormalized : fixed stackoverflow and array type parsing when source forget to send "items" details for it Sep 3, 2021
@etsybaev
Copy link
Contributor Author

etsybaev commented Sep 3, 2021

/test connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1198730462
✅ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1198730462

@etsybaev
Copy link
Contributor Author

etsybaev commented Sep 3, 2021

This PR should fix issues: 5529, 5472, 5486, 4778 issues

@etsybaev
Copy link
Contributor Author

etsybaev commented Sep 6, 2021

/test connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1206170517
✅ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1206170517

@jrhizor jrhizor temporarily deployed to more-secrets September 6, 2021 13:31 Inactive
@etsybaev
Copy link
Contributor Author

etsybaev commented Sep 6, 2021

/publish connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1206293657
✅ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1206293657

@jrhizor jrhizor temporarily deployed to more-secrets September 6, 2021 14:12 Inactive
@etsybaev etsybaev merged commit e2c593e into master Sep 6, 2021
@etsybaev etsybaev deleted the etsybaev/5486-dest-bigquery-norm-fixed-parsing-array branch September 6, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment