-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Declare Oauth init parameters for 4 connector #6438
🎉 Declare Oauth init parameters for 4 connector #6438
Conversation
…es, Instagram, Salesforce
/test connector=connectors/source-facebook-marketing
|
/test connector=connectors/source-facebook-pages
|
/test connector=connectors/source-instagram
|
/test connector=connectors/source-salesforce
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update all the oauthFlowInitParameters according to reference
airbyte/airbyte-protocol/models/src/main/resources/airbyte_protocol/airbyte_protocol.yaml
Line 216 in 3378ba4
description: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Zirochkaa Google Ads is here. As for the rest of Google connectors, @gaart took over this issue, so I did not touch them. |
Beware, we're having to slightly modify the oauth specs in this PR: So connectors will have to be tweaked accordingly |
In the case of facebook connectors, see this comment too: #5989 (comment) |
…urochkin/annotate-oauth-init-parameters-for-initial-cloud-release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yevhenii-ldv could you update this to the new spec format?
"authSpecification": { | ||
"auth_type": "oauth2.0", | ||
"oauth2Specification": { | ||
"oauthFlowInitParameters": [["access_token"]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be updated as a output parameter using the new spec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sherifnada Done, could u review this PR one more time, please?
…urochkin/annotate-oauth-init-parameters-for-initial-cloud-release � Conflicts: � docs/integrations/sources/facebook-marketing.md
…urochkin/annotate-oauth-init-parameters-for-initial-cloud-release
/test connector=connectors/source-facebook-pages
|
/test connector=connectors/source-facebook-marketing
|
/test connector=connectors/source-instagram
|
/publish connector=connectors/source-facebook-marketing
|
/publish connector=connectors/source-instagram
|
/publish connector=connectors/source-salesforce
|
/publish connector=connectors/source-facebook-pages
|
/publish connector=connectors/source-salesforce
|
/publish connector=connectors/source-salesforce
|
* Annotate Oauth init parameters for connectors: Facebook Marketing/Pages, Instagram, Salesforce
Annotate Oauth init parameters for connectors: Facebook Marketing/Pages, Instagram, Salesforce
What
closes #6166 (except for Google Connectors).
How
Describe the solution
Recommended reading order
x.java
y.python
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described here