Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destination BigQuery: add support to dataset starting with numbers #6733

Merged
merged 4 commits into from
Oct 6, 2021
Merged

Destination BigQuery: add support to dataset starting with numbers #6733

merged 4 commits into from
Oct 6, 2021

Conversation

marcosmarxm
Copy link
Member

What

Closes #6731

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Oct 4, 2021
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Oct 4, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1305179413
✅ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1305179413
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    11      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     117      6    95%
	 normalization/transform_catalog/reserved_keywords.py                 10      0   100%
	 normalization/transform_catalog/stream_processor.py                 349    199    43%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         143     36    75%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1039    391    62%

@jrhizor jrhizor temporarily deployed to more-secrets October 4, 2021 20:28 Inactive
sherifnada
sherifnada approved these changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a test case for this?

ideally the flow would be:

  1. revert the code change you made (temporarily)
  2. create a test case that is failing due to this error
  3. re-add the change, and see the test case is succeeding

docs/integrations/destinations/bigquery.md Outdated Show resolved Hide resolved
@marcosmarxm marcosmarxm temporarily deployed to more-secrets October 6, 2021 00:33 Inactive
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Oct 6, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1309927868
✅ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1309927868
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    11      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     117      6    95%
	 normalization/transform_catalog/reserved_keywords.py                 10      0   100%
	 normalization/transform_catalog/stream_processor.py                 349    199    43%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         143     36    75%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1039    391    62%

@jrhizor jrhizor temporarily deployed to more-secrets October 6, 2021 00:43 Inactive
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Oct 6, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1310009995
✅ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1310009995

@jrhizor jrhizor temporarily deployed to more-secrets October 6, 2021 01:14 Inactive
@marcosmarxm marcosmarxm temporarily deployed to more-secrets October 6, 2021 12:04 Inactive
@marcosmarxm marcosmarxm merged commit 1184920 into master Oct 6, 2021
@marcosmarxm marcosmarxm deleted the marcos/destination-bq-support-ds branch October 6, 2021 16:00
@jrhizor jrhizor mentioned this pull request Oct 7, 2021
Merged
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@marcosmarxm @schlattk
Destination BigQuery: add support to dataset starting with numbers (a…
62799a4 
…irbytehq#6733)

* change check function

* make test harder

* change tests

* add tests˜
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherifnada sherifnada sherifnada approved these changes

@etsybaev etsybaev Awaiting requested review from etsybaev

@harshithmullapudi harshithmullapudi Awaiting requested review from harshithmullapudi

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/bigquery connectors/destinations-warehouse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Destination BigQuery: can create connector with dataset_id starting with numbers
4 participants
@marcosmarxm @sherifnada @jrhizor @karinakuz