Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 CDK: HttpStream authenticator property should also returns AuthBase objects #6844

Closed
wants to merge 1 commit into from
Closed

🐛 CDK: HttpStream authenticator property should also returns AuthBase objects #6844

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions airbyte-cdk/python/airbyte_cdk/sources/streams/http/http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,10 @@ class HttpStream(Stream, ABC):
def __init__(self, authenticator: Union[AuthBase, HttpAuthenticator] = None):
self._session = requests.Session()

self._authenticator = NoAuth()
self._authenticator = authenticator or NoAuth()
midavadim marked this conversation as resolved.
Show resolved Hide resolved

if isinstance(authenticator, AuthBase):
self._session.auth = authenticator
elif authenticator:
self._authenticator = authenticator

if self.use_cache:
self.cache_file = self.request_cache()
Expand Down