Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 New Source: SearchMetrics #6992

Merged
merged 13 commits into from
Dec 22, 2021
Merged

🎉 New Source: SearchMetrics #6992

merged 13 commits into from
Dec 22, 2021

Conversation

lazebnyi
Copy link
Collaborator

What

#5795 - New Source: SearchMetrics

How

Using CDK and custom methods implemented the connector logic for SearchMetrics as a source for Airbyte.

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Oct 13, 2021
@lazebnyi lazebnyi temporarily deployed to more-secrets October 13, 2021 10:44 Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets October 18, 2021 08:43 Inactive
@lazebnyi lazebnyi linked an issue Oct 18, 2021 that may be closed by this pull request
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Oct 18, 2021

/test connector=connectors/source-search-metrics

🕑 connectors/source-search-metrics https://github.com/airbytehq/airbyte/actions/runs/1353865672
❌ connectors/source-search-metrics https://github.com/airbytehq/airbyte/actions/runs/1353865672
🐛 https://gradle.com/s/7pcdyhvklm5ge

@jrhizor jrhizor temporarily deployed to more-secrets October 18, 2021 08:58 Inactive
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Oct 18, 2021

/test connector=connectors/source-search-metrics

🕑 connectors/source-search-metrics https://github.com/airbytehq/airbyte/actions/runs/1353954073
✅ connectors/source-search-metrics https://github.com/airbytehq/airbyte/actions/runs/1353954073
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     111     11    90%
	 ------------------------------------------------------------------------
	 TOTAL                                                  856    416    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                       Stmts   Miss  Cover
	 --------------------------------------------------------------
	 base_python/__init__.py                       13      0   100%
	 base_python/catalog_helpers.py                10      6    40%
	 base_python/cdk/__init__.py                    0      0   100%
	 base_python/cdk/abstract_source.py            83     59    29%
	 base_python/cdk/streams/__init__.py            0      0   100%
	 base_python/cdk/streams/auth/__init__.py       0      0   100%
	 base_python/cdk/streams/auth/core.py           8      1    88%
	 base_python/cdk/streams/auth/jwt.py            5      5     0%
	 base_python/cdk/streams/auth/oauth.py         37     26    30%
	 base_python/cdk/streams/auth/token.py          9      4    56%
	 base_python/cdk/streams/core.py               63     32    49%
	 base_python/cdk/streams/exceptions.py         10      2    80%
	 base_python/cdk/streams/http.py               67     33    51%
	 base_python/cdk/streams/rate_limiting.py      30     14    53%
	 base_python/cdk/utils/__init__.py              0      0   100%
	 base_python/cdk/utils/casing.py                4      0   100%
	 base_python/client.py                         56     33    41%
	 base_python/entrypoint.py                     70     56    20%
	 base_python/integration.py                    52     25    52%
	 base_python/logger.py                         33     19    42%
	 base_python/schema_helpers.py                 56     41    27%
	 base_python/source.py                         51     34    33%
	 main_dev.py                                    3      3     0%
	 --------------------------------------------------------------
	 TOTAL                                        660    393    40%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 /actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-search-metrics/.venv/lib/python3.8/site-packages/coverage/control.py:761: CoverageWarning: No data was collected. (no-data-collected)
	 Name                                Stmts   Miss  Cover
	   self._warn("No data was collected.", slug="no-data-collected")
	 -------------------------------------------------------
	 source_search_metrics/__init__.py       2      2     0%
	 source_search_metrics/source.py       177    177     0%
	 source_search_metrics/utils.py          3      3     0%
	 -------------------------------------------------------
	 TOTAL                                 182    182     0%

@lazebnyi lazebnyi temporarily deployed to more-secrets October 18, 2021 09:20 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 18, 2021 09:21 Inactive
@lazebnyi lazebnyi marked this pull request as ready for review October 18, 2021 09:47
@lazebnyi lazebnyi temporarily deployed to more-secrets October 18, 2021 09:48 Inactive
@lazebnyi lazebnyi force-pushed the lazebnyi/5795-search-metrics branch from aff9dea to ec86592 Compare October 18, 2021 19:40
@lazebnyi lazebnyi requested a review from marcosmarxm October 18, 2021 19:42
@lazebnyi lazebnyi temporarily deployed to more-secrets October 18, 2021 19:42 Inactive
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @lazebnyi

@marcosmarxm
Copy link
Member

marcosmarxm commented Oct 25, 2021

/publish connector=connectors/source-search-metrics

🕑 connectors/source-search-metrics https://github.com/airbytehq/airbyte/actions/runs/1382959842
❌ connectors/source-search-metrics https://github.com/airbytehq/airbyte/actions/runs/1382959842

@jrhizor jrhizor temporarily deployed to more-secrets October 25, 2021 21:12 Inactive
@marcosmarxm
Copy link
Member

marcosmarxm commented Nov 9, 2021

/publish connector=connectors/source-search-metrics

🕑 connectors/source-search-metrics https://github.com/airbytehq/airbyte/actions/runs/1441475039
❌ connectors/source-search-metrics https://github.com/airbytehq/airbyte/actions/runs/1441475039

@jrhizor jrhizor temporarily deployed to more-secrets November 9, 2021 21:30 Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets December 22, 2021 18:56 Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets December 22, 2021 19:08 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 22, 2021 19:09 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 22, 2021 19:26 Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets December 22, 2021 19:54 Inactive
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Dec 22, 2021

/publish connector=connectors/source-search-metrics run-tests=false

🕑 connectors/source-search-metrics https://github.com/airbytehq/airbyte/actions/runs/1612843775
✅ connectors/source-search-metrics https://github.com/airbytehq/airbyte/actions/runs/1612843775

@jrhizor jrhizor temporarily deployed to more-secrets December 22, 2021 19:56 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 22, 2021 19:57 Inactive
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Dec 22, 2021

/publish connector=connectors/source-search-metrics run-tests=false

🕑 connectors/source-search-metrics https://github.com/airbytehq/airbyte/actions/runs/1612916818
✅ connectors/source-search-metrics https://github.com/airbytehq/airbyte/actions/runs/1612916818

@lazebnyi lazebnyi temporarily deployed to more-secrets December 22, 2021 20:20 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 22, 2021 20:20 Inactive
@lazebnyi lazebnyi merged commit 6d3a80a into master Dec 22, 2021
@lazebnyi lazebnyi deleted the lazebnyi/5795-search-metrics branch December 22, 2021 20:31
@lazebnyi lazebnyi temporarily deployed to more-secrets December 22, 2021 20:32 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Source: SearchMetrics
5 participants