Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix data type tests in CdcPostgresSourceDatatypeTest #7339

Merged
merged 22 commits into from
Nov 2, 2021
Merged

🐛 Fix data type tests in CdcPostgresSourceDatatypeTest #7339

merged 22 commits into from
Nov 2, 2021

Conversation

sashaNeshcheret
Copy link
Contributor

@sashaNeshcheret sashaNeshcheret commented Oct 25, 2021 •
edited
Loading

What

Fix data type tests in CdcPostgresSourceDataTypeTest

How

Created custom PostgressConvertet that implements CustomConverter

Recommended reading order

  1. x.java
  2. y.yaml
  3. z.json
  4. k.md

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Oct 25, 2021
@sashaNeshcheret sashaNeshcheret linked an issue Oct 25, 2021 that may be closed by this pull request
Fix data type tests in CdcPostgresSourceDatatypeTest #5382
Closed
@sashaNeshcheret sashaNeshcheret temporarily deployed to more-secrets October 25, 2021 17:19 Inactive
@sashaNeshcheret sashaNeshcheret changed the title Fix data type tests in CdcPostgresSourceComprehensiveTest Fix data type tests in CdcPostgresSourceDatatypeTest Oct 26, 2021
@sashaNeshcheret sashaNeshcheret temporarily deployed to more-secrets October 26, 2021 09:49 Inactive
@sashaNeshcheret sashaNeshcheret temporarily deployed to more-secrets October 26, 2021 10:05 Inactive
@sashaNeshcheret sashaNeshcheret requested review from DoNotPanicUA and removed request for etsybaev October 26, 2021 10:06
@alexandr-shegeda
Copy link
Contributor

@sashaNeshcheret please bump the strict-encrypt version as well

DoNotPanicUA
DoNotPanicUA previously approved these changes Oct 26, 2021
View reviewed changes
@sashaNeshcheret sashaNeshcheret temporarily deployed to more-secrets October 26, 2021 11:07 Inactive
@DoNotPanicUA DoNotPanicUA mentioned this pull request Oct 26, 2021
Merged
39 tasks
@DoNotPanicUA DoNotPanicUA self-requested a review October 26, 2021 15:26
@DoNotPanicUA DoNotPanicUA dismissed their stale review October 26, 2021 15:26

might be a conflict with PR #7386 Please coordinate DebeziumConverterUtils.java creation somewhere in one place.

@sashaNeshcheret sashaNeshcheret temporarily deployed to more-secrets October 26, 2021 16:12 Inactive
@sashaNeshcheret sashaNeshcheret changed the title Fix data type tests in CdcPostgresSourceDatatypeTest bug Fix data type tests in CdcPostgresSourceDatatypeTest Oct 26, 2021
@sashaNeshcheret sashaNeshcheret changed the title bug Fix data type tests in CdcPostgresSourceDatatypeTest 🐛 Fix data type tests in CdcPostgresSourceDatatypeTest Oct 26, 2021
@sashaNeshcheret sashaNeshcheret temporarily deployed to more-secrets October 28, 2021 14:11 Inactive
@sashaNeshcheret
Copy link
Contributor Author

sashaNeshcheret commented Oct 28, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-postgres-strict-encrypt

🕑 connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1395293975
✅ connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1395293975
No Python unittests run

@jrhizor jrhizor temporarily deployed to more-secrets October 28, 2021 15:29 Inactive
@sashaNeshcheret sashaNeshcheret temporarily deployed to more-secrets October 28, 2021 15:45 Inactive
@sashaNeshcheret sashaNeshcheret temporarily deployed to more-secrets October 28, 2021 16:09 Inactive
@sashaNeshcheret
Copy link
Contributor Author

sashaNeshcheret commented Oct 28, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-postgres-strict-encrypt

🕑 connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1395541247
✅ connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1395541247

@jrhizor jrhizor temporarily deployed to more-secrets October 28, 2021 16:36 Inactive
@sashaNeshcheret sashaNeshcheret temporarily deployed to more-secrets October 30, 2021 02:36 Inactive
@sashaNeshcheret sashaNeshcheret temporarily deployed to more-secrets October 31, 2021 16:13 Inactive
@sashaNeshcheret sashaNeshcheret temporarily deployed to more-secrets November 2, 2021 13:10 Inactive
@sashaNeshcheret sashaNeshcheret temporarily deployed to more-secrets November 2, 2021 13:15 Inactive
@sashaNeshcheret
Copy link
Contributor Author

sashaNeshcheret commented Nov 2, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/1412574672
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/1412574672
No Python unittests run

@jrhizor jrhizor temporarily deployed to more-secrets November 2, 2021 13:58 Inactive
@sashaNeshcheret sashaNeshcheret merged commit 7cf31ea into master Nov 2, 2021
@sashaNeshcheret sashaNeshcheret deleted the oneshcheret/5382-fix-data-type-cdc-postgres branch November 2, 2021 15:46
@jrhizor jrhizor mentioned this pull request Nov 3, 2021
Merged
yurii-bidiuk added a commit that referenced this pull request Nov 3, 2021
@yurii-bidiuk
aligned converter utils with #7339
72172cb
lmossman pushed a commit that referenced this pull request Nov 3, 2021
@sashaNeshcheret @sherifnada @lmossman
🐛 Fix data type tests in CdcPostgresSourceDatatypeTest (#7339)
dd0ff2b 
* Fix data type tests in CdcPostgresSourceComprehensiveTest

* update style format

* bump version for postgres source

* bump version for postgres source in json definition

* remove unnecessary comments from test and bump version for postgres strict encrypt source

* resolved potential conflicts with debezium utils in mssql converter implementation

* resolved potential conflicts with debezium utils in mssql converter implementation

* Update notes for money type in postgres.md

Co-authored-by: Sherif A. Nada <snadalive@gmail.com>

* Update docs/integrations/sources/postgres.md

Co-authored-by: Sherif A. Nada <snadalive@gmail.com>

* added test cases for converting data values for postgres cdc, remove time zone utc from test container

* remove redundant void message from test

Co-authored-by: Sherif A. Nada <snadalive@gmail.com>

* update style format

* fix time zone in DebeziumConverterUtilsTest

* set utc time zone in DataTypeUtils

* set utc time zone for date format

* revert changes regarding timezone in date format, disable tests with number and duration

Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
yurii-bidiuk added a commit that referenced this pull request Nov 4, 2021
@yurii-bidiuk
aligned converter utils with #7339
8df87e2
yurii-bidiuk added a commit that referenced this pull request Nov 5, 2021
@yurii-bidiuk @DoNotPanicUA
🐛 Source MSSQL: fix data type (smalldatetime, smallmoney) conversion …
56db806 
…from mssql source (#5609) (#7386)

* Fix data type (smalldatetime, smallmoney) conversion from mssql source (#5609)

* Fixed code format

* Bumb new version

* Update documentation (mssql.md)

* formating

* fixed converter properties

* aligned converter utils with #7339

Co-authored-by: Andrii Leonets <30464745+DoNotPanicUA@users.noreply.github.com>
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@sashaNeshcheret @sherifnada @schlattk
🐛 Fix data type tests in CdcPostgresSourceDatatypeTest (airbytehq#7339)
40b3819 
* Fix data type tests in CdcPostgresSourceComprehensiveTest

* update style format

* bump version for postgres source

* bump version for postgres source in json definition

* remove unnecessary comments from test and bump version for postgres strict encrypt source

* resolved potential conflicts with debezium utils in mssql converter implementation

* resolved potential conflicts with debezium utils in mssql converter implementation

* Update notes for money type in postgres.md

Co-authored-by: Sherif A. Nada <snadalive@gmail.com>

* Update docs/integrations/sources/postgres.md

Co-authored-by: Sherif A. Nada <snadalive@gmail.com>

* added test cases for converting data values for postgres cdc, remove time zone utc from test container

* remove redundant void message from test

Co-authored-by: Sherif A. Nada <snadalive@gmail.com>

* update style format

* fix time zone in DebeziumConverterUtilsTest

* set utc time zone in DataTypeUtils

* set utc time zone for date format

* revert changes regarding timezone in date format, disable tests with number and duration

Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@yurii-bidiuk @DoNotPanicUA @schlattk
🐛 Source MSSQL: fix data type (smalldatetime, smallmoney) conversion …
f535283 
…from mssql source (airbytehq#5609) (airbytehq#7386)

* Fix data type (smalldatetime, smallmoney) conversion from mssql source (airbytehq#5609)

* Fixed code format

* Bumb new version

* Update documentation (mssql.md)

* formating

* fixed converter properties

* aligned converter utils with airbytehq#7339

Co-authored-by: Andrii Leonets <30464745+DoNotPanicUA@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherifnada sherifnada sherifnada approved these changes

@alexandr-shegeda alexandr-shegeda Awaiting requested review from alexandr-shegeda

@DoNotPanicUA DoNotPanicUA Awaiting requested review from DoNotPanicUA

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation gl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix data type tests in CdcPostgresSourceDatatypeTest
5 participants
@sashaNeshcheret @alexandr-shegeda @sherifnada @DoNotPanicUA @jrhizor