Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 New destination: ScyllaDB #7468

Merged
merged 5 commits into from
Nov 16, 2021
Merged

🎉 New destination: ScyllaDB #7468

merged 5 commits into from
Nov 16, 2021

Conversation

itaseskii
Copy link
Contributor

@itaseskii itaseskii commented Oct 28, 2021 •
edited
Loading

What

The MR adds new destination connector for ScyllaDB

How

Using the ScyllaDB Java Driver https://docs.scylladb.com/using-scylla/drivers/cql-drivers/scylla-java-driver/

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@CLAassistant
Copy link

CLAassistant commented Oct 28, 2021 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ itaseskii
✅ marcosmarxm
❌ itaseski

itaseski seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Oct 28, 2021
@itaseskii itaseskii changed the title tada New destination: ScyllaDB 🎉 New destination: ScyllaDB Oct 28, 2021
@itaseskii
Copy link
Contributor Author

itaseskii commented Oct 28, 2021 •
edited
Loading

I would like to submit my ScyllaDB Destination Connector for code review. As an attachment I am sending you a screenshot of the passing acceptance test :)
Screenshot_7

@itaseskii itaseskii mentioned this pull request Oct 28, 2021
Closed
@marcosmarxm marcosmarxm self-assigned this Nov 8, 2021
marcosmarxm
marcosmarxm reviewed Nov 11, 2021
View reviewed changes
...n-scylla/src/main/java/io/airbyte/integrations/destination/scylla/ScyllaNameTransformer.java
String outputTable(String streamName) {
var tableName = super.getRawTableName(streamName.toLowerCase()).substring(1);
// max allowed length for a scylla table is 48 characters
return tableName.length() > 48 ? tableName.substring(0, 48) : tableName;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return tableName.length() > 48 ? tableName.substring(0, 48) : tableName;
return tableName.length() > MAX_TABLE_LENGTH_ALLOW ? tableName.substring(0, 48) : tableName;

Why do you think to change to a variable? with this you can remove the comment and be more explicated about this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcosmarxm good idea. done :)

@marcosmarxm
Copy link
Member

Hello @itaseskii ! Sorry to not finished your contribution before the date stipulated in the contest. All contributions made before 15-November are eligible to receive the award. We're trying to review your contribution as soon as possible.

@marcosmarxm marcosmarxm mentioned this pull request Nov 15, 2021
Closed
@marcosmarxm marcosmarxm merged commit fcba526 into airbytehq:master Nov 16, 2021
This was referenced Nov 16, 2021
Closed
Merged
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@itaseskii @marcosmarxm @schlattk
🎉 New destination: ScyllaDB (airbytehq#7468)
319b111 
* add scylla destination connector

* minor fixes

Co-authored-by: itaseski <ivica.taseski@seavus.com>
Co-authored-by: Marcos Marx <marcosmarxm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmarxm marcosmarxm marcosmarxm left review comments

Assignees

@marcosmarxm marcosmarxm

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/destination/scylla connectors/destinations-database gl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@itaseskii @CLAassistant @marcosmarxm @karinakuz @octavia-squidington-iii