Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include requester and stats fields in tickets stream #7486

Merged
merged 10 commits into from
Nov 15, 2021
Merged

Include requester and stats fields in tickets stream #7486

merged 10 commits into from
Nov 15, 2021

Conversation

t0hai
Copy link
Contributor

@t0hai t0hai commented Oct 29, 2021 •
edited
Loading

What

Include requester and stats fields in tickets stream

How

Add requester and stats to include URL parameter for API requests to tickets endpoint

Recommended reading order

  1. source_freshdesk/api.py
  2. schemas/tickets.json

Pre-merge Checklist

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing.
  • Code reviews completed
  • Documentation updated
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

screenshot-airbyte risus xyz_8000-2021 10 29-11_05_17

@github-actions github-actions bot added the area/connectors Connector related issues label Oct 29, 2021
@t0hai t0hai force-pushed the n0rritt/source-freshdesk/add_stats_and_requester_fields_in_tickets branch from bc8f7a2 to f9d829d Compare October 29, 2021 09:14
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Oct 29, 2021
@marcosmarxm
Copy link
Member

thanks for the contribution @n0rritt I'll review this tomorrow

@marcosmarxm marcosmarxm temporarily deployed to more-secrets November 15, 2021 14:54 Inactive
@marcosmarxm marcosmarxm temporarily deployed to more-secrets November 15, 2021 16:00 Inactive
@marcosmarxm marcosmarxm merged commit c99335f into airbytehq:master Nov 15, 2021
This was referenced Nov 16, 2021
Closed
Merged
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@marcosmarxm @schlattk
Include requester and stats fields in tickets stream (airbytehq#7486)
365e380 
* Include requester and stats in tickets stream

* Update documentation, rebase to lastest master state and bump version

* run format

* format files

* correct other file

* correct files

Co-authored-by: Marcos Marx <marcosmarxm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmarxm marcosmarxm marcosmarxm approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@t0hai @marcosmarxm @octavia-squidington-iii