-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Source Recharge: improve 'backoff' for HTTP requests #7626
Conversation
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
/test connector=connectors/source-recharge
|
airbyte-integrations/connectors/source-recharge/source_recharge/api.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-recharge/source_recharge/api.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
@grubberr |
/publish connector=connectors/source-recharge
|
* backoff for successful but incomplete responses Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk grubberr@gmail.com
What
This Airbyte connector can fail time to time because of incorrect HTTP responses from API server.
For example you can catch such HTTP response
As you can see 'Content-Length' of response much bigger then real response body length.
I propose to re-request such broken responses, extending current backoff mechanism.
How
Describe the solution
Recommended reading order
x.java
y.python
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described here