Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Destination BQ Denormalized: handle null values in fields described by a $ref schema #7804

Merged
merged 3 commits into from
Nov 10, 2021

Conversation

sherifnada
Copy link
Contributor

@sherifnada sherifnada commented Nov 10, 2021

What

#7736 added a partial fix for this case but didn't handle the situation where the field described by $ref is either null or not present. This PR handles this case and adds tests.

How

Only attempt to set the value of the property to a string if it is present and not null in the record being processed.

Recommended reading order

  1. BigQueryDenormalizedRecordConsumer.java
  2. BigQueryDenormalizedDestinationTest.java

Pre-merge checklist

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@github-actions github-actions bot added the area/connectors Connector related issues label Nov 10, 2021
@sherifnada sherifnada changed the title Destination BQ Denormalized: handle null values in fields described by a $ref schema 🐛 Destination BQ Denormalized: handle null values in fields described by a $ref schema Nov 10, 2021
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Nov 10, 2021
@sherifnada sherifnada temporarily deployed to more-secrets November 10, 2021 05:29 Inactive
@sherifnada
Copy link
Contributor Author

sherifnada commented Nov 10, 2021

/publish connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1442788641
✅ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1442788641

@jrhizor jrhizor temporarily deployed to more-secrets November 10, 2021 05:36 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants