Add to the new connection flow form with an existing source and dest… #7831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/frontend
area/platform
jrhizor
approved these changes
Nov 10, 2021
There was a problem hiding this comment.
Functionally works.
Good to go except for some styling errors and confusing behavior when there are no sources or destinations in the dropdown:
- There's a rectangle showing behind the rounded corners.
- The header should match the styling of the one below it (the border underneath). And we should probably label input field with "Source"
- Can we hide this option entirely when the user doesn't have any sources configured? Same for destinations.
- Instead of "Save changes" can we say "Use existing source"
Everything else: will fix. |
This was referenced Nov 16, 2021
schlattk
pushed a commit
to schlattk/airbyte
that referenced
this pull request
Jan 4, 2022
…airbytehq#7831) * Add to the new connection flow form with an existing source and destination dropdown * Hide existing block when sources or destinations lists are empty * Fix e2e connection tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ination dropdown
What
Closes #4093
Adds new subform that allows creating from current sources and destinations.
Should be merged after #7178 as currently there is an issue when it displays connector check