Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 Pipedrive: extend schema for "persons" stream #7875

Merged
merged 5 commits into from
Nov 17, 2021
Merged

🎉 Pipedrive: extend schema for "persons" stream #7875

merged 5 commits into from
Nov 17, 2021

Conversation

grubberr
Copy link
Contributor

Signed-off-by: Sergey Chvalyuk grubberr@gmail.com

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@grubberr
extend schema for "persons" stream
0ca1e3f 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr temporarily deployed to more-secrets November 11, 2021 18:42 Inactive
@github-actions github-actions bot added the area/connectors Connector related issues label Nov 11, 2021
@grubberr grubberr changed the title extend schema for "persons" stream 🎉 Pipedrive: extend schema for "persons" stream Nov 11, 2021
@grubberr
pipedrive.md updated
63e2e27 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Nov 11, 2021
@grubberr grubberr linked an issue Nov 11, 2021 that may be closed by this pull request
Source Pipedrive Invalid JSON schema #7779
Closed
@grubberr grubberr self-assigned this Nov 11, 2021
@grubberr grubberr temporarily deployed to more-secrets November 11, 2021 18:46 Inactive
@grubberr
Merge branch 'master' into grubberr/7779-source-pipedrive
00d0509 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
bump version 0.1.7 -> 0.1.8
e5edbbe 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr temporarily deployed to more-secrets November 16, 2021 07:37 Inactive
antixar
antixar approved these changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@antixar antixar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! This fix is obvious, please publish it

@grubberr
Copy link
Contributor Author

grubberr commented Nov 17, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-pipedrive

🕑 connectors/source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/1472219378
✅ connectors/source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/1472219378

@jrhizor jrhizor temporarily deployed to more-secrets November 17, 2021 14:51 Inactive
@grubberr
re-generate source_specs.yaml
df1b53c 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr merged commit d24d25f into master Nov 17, 2021
@grubberr grubberr deleted the grubberr/7779-source-pipedrive branch November 17, 2021 15:07
@grubberr grubberr temporarily deployed to more-secrets November 17, 2021 15:08 Inactive
@jrhizor jrhizor mentioned this pull request Nov 18, 2021
Merged
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@grubberr @schlattk
🎉 Pipedrive: extend schema for "persons" stream (airbytehq#7875)
a827eef 
* extend schema for "persons" stream

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@midavadim midavadim midavadim approved these changes

@antixar antixar antixar approved these changes

@lazebnyi lazebnyi lazebnyi approved these changes

Assignees

@grubberr grubberr

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Source Pipedrive Invalid JSON schema
5 participants
@grubberr @midavadim @antixar @lazebnyi @jrhizor