Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance API for use by cloud to provide per-connector billing info #7893

Merged
merged 11 commits into from
Nov 16, 2021
Merged

Enhance API for use by cloud to provide per-connector billing info #7893

merged 11 commits into from
Nov 16, 2021

Conversation

airbyte-jenny
Copy link
Contributor

What

Enhance API for use by cloud to provide per-connector billing info

How

Modifies the method call to take an optional parameter for whether to include deleted connections.

@github-actions github-actions bot added area/platform issues related to the platform area/server labels Nov 12, 2021
jrhizor
jrhizor suggested changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@jrhizor jrhizor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The listConnectionsForWorkspace shouldn't show deleted connections on the connection list page of the webapp. That option should be available at the API level.

@github-actions github-actions bot added area/api Related to the api area/documentation Improvements or additions to documentation labels Nov 12, 2021
@airbyte-jenny airbyte-jenny temporarily deployed to more-secrets November 12, 2021 20:04 Inactive
@airbyte-jenny airbyte-jenny temporarily deployed to more-secrets November 12, 2021 20:49 Inactive
@airbyte-jenny airbyte-jenny temporarily deployed to more-secrets November 12, 2021 21:29 Inactive
@airbyte-jenny airbyte-jenny temporarily deployed to more-secrets November 12, 2021 23:21 Inactive
@airbyte-jenny airbyte-jenny mentioned this pull request Nov 12, 2021
Closed
@airbyte-jenny airbyte-jenny temporarily deployed to more-secrets November 15, 2021 17:26 Inactive
@airbyte-jenny airbyte-jenny temporarily deployed to more-secrets November 15, 2021 17:46 Inactive
@airbyte-jenny airbyte-jenny temporarily deployed to more-secrets November 15, 2021 18:21 Inactive
jrhizor
jrhizor approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@jrhizor jrhizor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine.

Would slightly prefer if the main list endpoint took something other than a WorkspaceIdRequestBody that had an optional "include_deleted" boolean so we'd be parameterizing existing endpoints instead of adding new ones.

airbyte-api/src/main/openapi/config.yaml Outdated Show resolved Hide resolved
airbyte-api/src/main/openapi/config.yaml Outdated Show resolved Hide resolved
@github-actions github-actions bot added the area/connectors Connector related issues label Nov 15, 2021
@airbyte-jenny airbyte-jenny temporarily deployed to more-secrets November 15, 2021 19:33 Inactive
@airbyte-jenny airbyte-jenny temporarily deployed to more-secrets November 15, 2021 20:13 Inactive
@airbyte-jenny airbyte-jenny temporarily deployed to more-secrets November 15, 2021 20:17 Inactive
@airbyte-jenny airbyte-jenny temporarily deployed to more-secrets November 15, 2021 20:21 Inactive
@airbyte-jenny airbyte-jenny temporarily deployed to more-secrets November 15, 2021 21:00 Inactive
@github-actions github-actions bot removed the area/connectors Connector related issues label Nov 15, 2021
@airbyte-jenny airbyte-jenny temporarily deployed to more-secrets November 15, 2021 21:15 Inactive
@airbyte-jenny airbyte-jenny temporarily deployed to more-secrets November 15, 2021 22:47 Inactive
@airbyte-jenny airbyte-jenny temporarily deployed to more-secrets November 16, 2021 17:38 Inactive
@airbyte-jenny airbyte-jenny merged commit d6c684b into master Nov 16, 2021
@airbyte-jenny airbyte-jenny deleted the airbyte-jenny/per-connector-billing branch November 16, 2021 18:15
This was referenced Nov 16, 2021
Closed
Merged
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@airbyte-jenny @schlattk
Enhance API for use by cloud to provide per-connector billing info (a…
963b74f 
…irbytehq#7893)

* Enhance API for use by cloud to provide per-connector billing information

* Add listAllConnectionsForWorkspace to include deleted

* Config for list all connections

* Merged master, and formatting

* Formatting

* Name change per PR suggestion

* Name change per PR suggestion

* Formatting again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhizor jrhizor jrhizor approved these changes

Assignees
No one assigned
Labels
area/api Related to the api area/documentation Improvements or additions to documentation area/platform issues related to the platform area/server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@airbyte-jenny @jrhizor