Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix server errors #7931

Merged
merged 2 commits into from
Nov 12, 2021
Merged

Fix server errors #7931

merged 2 commits into from
Nov 12, 2021

Conversation

jamakase
Copy link
Contributor

@jamakase jamakase commented Nov 12, 2021

What

Fixes ConfigProvider injection: now it is injected before ErrorBoundary so absent config won't through errors.
Add e2e tests for 500 and 502 errors from server.

Closes #7880

@jamakase jamakase requested a review from jrhizor November 12, 2021 20:27
@jamakase jamakase temporarily deployed to more-secrets November 12, 2021 20:27 Inactive
@github-actions github-actions bot added area/frontend area/platform issues related to the platform labels Nov 12, 2021
@jamakase jamakase self-assigned this Nov 12, 2021
@jrhizor
Copy link
Contributor

jrhizor commented Nov 12, 2021

Are the cypress test timeouts related?

@jamakase jamakase temporarily deployed to more-secrets November 12, 2021 23:19 Inactive
@jamakase jamakase temporarily deployed to more-secrets November 12, 2021 23:41 Inactive
@jamakase
Copy link
Contributor Author

Are the cypress test timeouts related?

Yay, Accidentally broke cypress runner command

@jamakase jamakase merged commit fbf08b6 into master Nov 12, 2021
@jamakase jamakase deleted the jamakase/add-server-error-checks branch November 12, 2021 23:57
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"server starting" page isn't showing on launch
2 participants