Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to Gradle 7.3.1 / Java 17 #7964

Merged
merged 34 commits into from
Dec 11, 2021
Merged

upgrade to Gradle 7.3.1 / Java 17 #7964

merged 34 commits into from
Dec 11, 2021

Conversation

jrhizor
Copy link
Contributor

@jrhizor jrhizor commented Nov 15, 2021

closes #6096

@github-actions github-actions bot added area/documentation Improvements or additions to documentation area/platform issues related to the platform area/scheduler area/server area/worker Related to worker labels Nov 15, 2021
@jrhizor jrhizor temporarily deployed to more-secrets November 15, 2021 05:38 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 15, 2021 05:58 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 15, 2021 06:17 Inactive
@github-actions github-actions bot added the area/connectors Connector related issues label Nov 15, 2021
@jrhizor jrhizor temporarily deployed to more-secrets November 15, 2021 06:25 Inactive
jrhizor
jrhizor commented Nov 15, 2021
View reviewed changes
airbyte-scheduler/persistence/src/main/resources/job_history_purge.sql
@@ -18,8 +18,8 @@ WHERE
) counts ON
jobs.scope = counts.scope
WHERE
-- job must be at least MINIMUM_AGE_IN_DAYS old or connection has more than EXCESSIVE_NUMBER_OF_JOBS
(
/* job must be at least MINIMUM_AGE_IN_DAYS old or connection has more than EXCESSIVE_NUMBER_OF_JOBS */
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to manually change these comments to this type before running the new Spotless version. Otherwise it puts the parenthesis on the same line as the comment.

@jrhizor jrhizor temporarily deployed to more-secrets November 15, 2021 06:44 Inactive
@jrhizor
Copy link
Contributor Author

jrhizor commented Nov 15, 2021

The test it's currently failing on for the platform build isn't something that I can reproduce locally. Going to investigate what the problem is exactly.

@jrhizor jrhizor temporarily deployed to more-secrets December 7, 2021 16:58 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 7, 2021 17:26 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 7, 2021 19:15 Inactive
@jrhizor
Copy link
Contributor Author

jrhizor commented Dec 8, 2021 •
edited
Loading

@davinchia This does work for M1 and non-M1 (outside of the temporal image of course which doesn't build yet)!

@edgao
Copy link
Contributor

edgao commented Dec 8, 2021

cool. I'm having trouble getting a fresh clone to build at all (even on master 🤷 ); happy to take jared's word for it.

sherifnada
sherifnada approved these changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@sherifnada sherifnada left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

multi-line strings here we go!

Jared, can you add a small blurb on the recommended path for upgrading to j17? what does a current java eng need to do to become compatible with this ugprade?

@jrhizor
Copy link
Contributor Author

jrhizor commented Dec 10, 2021

@sherifnada:

Created #8708 to track the connectors team actually bumping all Java connectors. If they run into any problems I might be able to help out / recognize some things.

Posted https://airbytehq.slack.com/archives/C019WEENQRM/p1639161450388200 with instructions.

@jrhizor jrhizor temporarily deployed to more-secrets December 10, 2021 19:05 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 10, 2021 19:40 Inactive
jrhizor and others added 7 commits December 10, 2021 15:58
@jrhizor
generate std source tests
559db88
@lmossman @jrhizor
fail zombie job attempts and add failure reason (#8709)
2d55198 
* fail zombie job attempts and add failure reason

* remove failure reason
@jrhizor
bump gcp dependencies to pick up grpc update (#8713)
09db967
@jrhizor
Bump Airbyte version from 0.33.9-alpha to 0.33.10-alpha (#8714)
9ddda0a 
Co-authored-by: jrhizor <jrhizor@users.noreply.github.com>
@sherifnada @jrhizor
Change CDK "Caching" header to "nested streams & caching"
f217727
@igrankova @grubberr
@sherifnada @jrhizor
Update fields in source-connectors specifications: file, freshdesk, g…
87046af 
…ithub, google-directory, google-workspace-admin-reports, iterable (#8524)

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

Co-authored-by: Serhii Chvaliuk <grubberr@gmail.com>
Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
@edgao @jrhizor
move S3Config into destination-s3; update dependencies accordingly (#…
b715f6a 
…8562)
@jrhizor jrhizor temporarily deployed to more-secrets December 11, 2021 00:00 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 11, 2021 00:02 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 11, 2021 00:22 Inactive
@jrhizor jrhizor merged commit 25674fc into master Dec 11, 2021
@jrhizor jrhizor deleted the jrhizor/upgrade-gradle-and-java branch December 11, 2021 00:57
@jrhizor jrhizor mentioned this pull request Dec 12, 2021
Merged
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@jrhizor @lmossman
@sherifnada @igrankova @grubberr @edgao @schlattk
upgrade to Gradle 7.3.1 / Java 17 (airbytehq#7964)
049eb06 
* upgrade gradle

* upgrade to Java 17 (and fix a few of the node versioning misses)

* oops

* try to run a different format version

* fix spotless by upgrading / reformatting some files

* fix ci settings

* upgrade mockito to avoid other errors

* undo bad format

* fix "incorrect" sql comments

* fmt

* add debug flag

* remove

* bump

* bump jooq to a version that has a java 17 dist

* fix

* remove logs

* oops

* revert jooq upgrade

* fix

* set up java for connector test

* fix yaml

* generate std source tests

* fail zombie job attempts and add failure reason (airbytehq#8709)

* fail zombie job attempts and add failure reason

* remove failure reason

* bump gcp dependencies to pick up grpc update (airbytehq#8713)

* Bump Airbyte version from 0.33.9-alpha to 0.33.10-alpha (airbytehq#8714)

Co-authored-by: jrhizor <jrhizor@users.noreply.github.com>

* Change CDK "Caching" header to "nested streams & caching"

* Update fields in source-connectors specifications: file, freshdesk, github, google-directory, google-workspace-admin-reports, iterable (airbytehq#8524)

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

Co-authored-by: Serhii Chvaliuk <grubberr@gmail.com>
Co-authored-by: Sherif A. Nada <snadalive@gmail.com>

* move S3Config into destination-s3; update dependencies accordingly (airbytehq#8562)

Co-authored-by: Lake Mossman <lake@airbyte.io>
Co-authored-by: jrhizor <jrhizor@users.noreply.github.com>
Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
Co-authored-by: Iryna Grankova <87977540+igrankova@users.noreply.github.com>
Co-authored-by: Serhii Chvaliuk <grubberr@gmail.com>
Co-authored-by: Edward Gao <edward.gao@airbyte.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davinchia davinchia davinchia approved these changes

@sherifnada sherifnada sherifnada approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation area/platform issues related to the platform area/scheduler area/server area/worker Related to worker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

upgrade to Java 17 (LTS)
6 participants
@jrhizor @sherifnada @edgao @davinchia @lmossman @igrankova