🎉 Source PostgreSQL: Handle the case when DB user doesn't has privileges to select the table #8010

alexandertsukanov · 2021-11-16T15:21:03Z

What

In the issue, #5172 was requested by the customer to don't list tables in Airbyte UI, where the user doesn't have access.

How

Added getPrivilegesTableForCurrentUser() method to AbstractDbSource.java class. This allows handling privileges for each source connector individually. If the method doesn't override in the child it will return an empty set.

🚨 User Impact 🚨

Are there any breaking changes? If yes, please make sure to include it here and in any changelogs with the 🚨🚨 emoji
What is the end result perceived by the user?

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed.

…ction settings

alexandertsukanov · 2021-11-16T15:38:20Z

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/1467590004
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/1467590004
No Python unittests run

alexandertsukanov · 2021-11-16T15:38:41Z

/test connector=connectors/source-postgres-strict-encrypt

🕑 connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1467591493
✅ connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1467591493
No Python unittests run

…ction settings

sashaNeshcheret · 2021-11-17T11:36:13Z

...ectors/source-jdbc/src/main/java/io/airbyte/integrations/source/jdbc/AbstractJdbcSource.java


  private static final String INTERNAL_SCHEMA_NAME = "schemaName";
  private static final String INTERNAL_TABLE_NAME = "tableName";
  private static final String INTERNAL_COLUMN_NAME = "columnName";
  private static final String INTERNAL_COLUMN_TYPE = "columnType";
+  protected static final String BLANK_STRING = "";


We can use StringUtils.EMPTY instead of adding new var

Fixed. Thanks.

alexandr-shegeda

LGTM. we can proceed with publishing and merge without airbyte review

…do_not_have_access

alexandertsukanov · 2021-11-19T12:19:08Z

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/1480938052
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/1480938052
No Python unittests run

alexandertsukanov · 2021-11-19T12:19:20Z

/test connector=connectors/source-postgres-strict-encrypt

🕑 connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1480938948
✅ connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1480938948
No Python unittests run

alexandertsukanov · 2021-11-19T14:20:42Z

/publish connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/1481368723
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/1481368723

alexandertsukanov · 2021-11-19T14:20:57Z

/publish connector=connectors/source-postgres-strict-encrypt

🕑 connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1481370015
✅ connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1481370015

…ges to select the table (airbytehq#8010) * airbyte-5172 Do not list tables we do not have access to in the connection settings * airbyte-5172 Do not list tables we do not have access to in the connection settings * airbyte-5172 Do not list tables we do not have access to in the connection settings * airbyte-5172 Do not list tables we do not have access to in the connection settings * airbyte-5172 Added docs, bump dockerfiles * airbyte-5172 Fix PR comments. * airbyte-5172 Fixed PR comments. * airbyte-5172 bumped connector version.

alexandertsukanov added 3 commits November 15, 2021 14:52

airbyte-5172 Do not list tables we do not have access to in the conne…

0c16481

…ction settings

airbyte-5172 Do not list tables we do not have access to in the conne…

7b9c700

…ction settings

airbyte-5172 Do not list tables we do not have access to in the conne…

3138ab4

…ction settings

alexandertsukanov requested a review from alexandr-shegeda November 16, 2021 15:21

github-actions bot added the area/connectors Connector related issues label Nov 16, 2021

alexandertsukanov linked an issue Nov 16, 2021 that may be closed by this pull request

Do not list tables we do not have access to in the connection settings #5172

Closed

jrhizor temporarily deployed to more-secrets November 16, 2021 15:40 Inactive

airbyte-5172 Do not list tables we do not have access to in the conne…

32a339d

…ction settings

alexandertsukanov temporarily deployed to more-secrets November 16, 2021 16:15 Inactive

alexandertsukanov requested a review from sashaNeshcheret November 17, 2021 09:02

alexandertsukanov mentioned this pull request Nov 17, 2021

[EPIC] Verify DB System tables and tables where user do not have privileges are not accessible to the user at Airbyte UI #8045

Closed

airbyte-5172 Added docs, bump dockerfiles

670b8dc

github-actions bot added the area/documentation Improvements or additions to documentation label Nov 17, 2021

alexandertsukanov temporarily deployed to more-secrets November 17, 2021 11:32 Inactive

sashaNeshcheret reviewed Nov 17, 2021

View reviewed changes

sashaNeshcheret approved these changes Nov 17, 2021

View reviewed changes

airbyte-5172 Fix PR comments.

26c5d79

alexandertsukanov temporarily deployed to more-secrets November 17, 2021 12:24 Inactive

airbyte-5172 Fixed PR comments.

89e1e8c

alexandertsukanov temporarily deployed to more-secrets November 17, 2021 12:26 Inactive

alexandr-shegeda approved these changes Nov 18, 2021

View reviewed changes

alexandr-shegeda marked this pull request as ready for review November 18, 2021 20:27

Merge branch 'master' into otsukanov/airbyte-5172_not_list_tables_we_…

12a19e2

…do_not_have_access

alexandertsukanov temporarily deployed to more-secrets November 19, 2021 12:20 Inactive

jrhizor temporarily deployed to more-secrets November 19, 2021 12:21 Inactive

jrhizor temporarily deployed to more-secrets November 19, 2021 14:23 Inactive

airbyte-5172 bumped connector version.

91104d4

alexandertsukanov merged commit dc04654 into master Nov 19, 2021

alexandertsukanov deleted the otsukanov/airbyte-5172_not_list_tables_we_do_not_have_access branch November 19, 2021 16:02

alexandertsukanov temporarily deployed to more-secrets November 19, 2021 16:03 Inactive

This was referenced Nov 19, 2021

Bump Airbyte version from 0.32.4-alpha to 0.32.5-alpha #8144

Closed

Bump Airbyte version from 0.32.4-alpha to 0.32.5-alpha #8147

Closed

Bump Airbyte version from 0.32.4-alpha to 0.32.5-alpha #8153

Merged

alafanechere mentioned this pull request Nov 25, 2021

Source Postgres: views are not listed during schema discovery #8254

Closed

jedwards-gc mentioned this pull request Dec 21, 2021

Postgres Source Connector Hides Materialized Views #9012

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 Source PostgreSQL: Handle the case when DB user doesn't has privileges to select the table #8010

🎉 Source PostgreSQL: Handle the case when DB user doesn't has privileges to select the table #8010

alexandertsukanov commented Nov 16, 2021 •

edited

Loading

alexandertsukanov commented Nov 16, 2021 •

edited by github-actions bot

Loading

alexandertsukanov commented Nov 16, 2021 •

edited by github-actions bot

Loading

sashaNeshcheret Nov 17, 2021

alexandertsukanov Nov 17, 2021

alexandr-shegeda left a comment

alexandertsukanov commented Nov 19, 2021 •

edited by github-actions bot

Loading

alexandertsukanov commented Nov 19, 2021 •

edited by github-actions bot

Loading

alexandertsukanov commented Nov 19, 2021 •

edited by github-actions bot

Loading

alexandertsukanov commented Nov 19, 2021 •

edited by github-actions bot

Loading

🎉 Source PostgreSQL: Handle the case when DB user doesn't has privileges to select the table #8010

🎉 Source PostgreSQL: Handle the case when DB user doesn't has privileges to select the table #8010

Conversation

alexandertsukanov commented Nov 16, 2021 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

alexandertsukanov commented Nov 16, 2021 • edited by github-actions bot Loading

alexandertsukanov commented Nov 16, 2021 • edited by github-actions bot Loading

sashaNeshcheret Nov 17, 2021

Choose a reason for hiding this comment

alexandertsukanov Nov 17, 2021

Choose a reason for hiding this comment

alexandr-shegeda left a comment

Choose a reason for hiding this comment

alexandertsukanov commented Nov 19, 2021 • edited by github-actions bot Loading

alexandertsukanov commented Nov 19, 2021 • edited by github-actions bot Loading

alexandertsukanov commented Nov 19, 2021 • edited by github-actions bot Loading

alexandertsukanov commented Nov 19, 2021 • edited by github-actions bot Loading

alexandertsukanov commented Nov 16, 2021 •

edited

Loading

alexandertsukanov commented Nov 16, 2021 •

edited by github-actions bot

Loading

alexandertsukanov commented Nov 16, 2021 •

edited by github-actions bot

Loading

alexandertsukanov commented Nov 19, 2021 •

edited by github-actions bot

Loading

alexandertsukanov commented Nov 19, 2021 •

edited by github-actions bot

Loading

alexandertsukanov commented Nov 19, 2021 •

edited by github-actions bot

Loading

alexandertsukanov commented Nov 19, 2021 •

edited by github-actions bot

Loading