-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SonarQube to CI #8362
Add SonarQube to CI #8362
Conversation
Created .properties file for sonarqube
.yml workflow for SonarQube scan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@h-chlor could you add an .md
file to the docs under contributing to airbyte
section explaining at a high level how sonarQube is integrated? e.g: where is it hosted, how is it run/triggered, etc... basically if you were onboarding someone into how to use sonarqube, what info do they need to know to become effective at working with it?
Hi @sherifnada , @h-chlor had initialised this PR only and I finished it. DevOps team prepared a similar doc |
@antixar indeed, the UML diagram is great! I think it's worth screenshotting + leaving a link to the whimsical in an I wasn't able to look at the code in details, but I think having something like this is a great insurance policy to help people make modifications to the code in the future |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs look great! Excited to have it in the repo. Just a few comments then feel free to merge.
Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
Follow-up issues: |
Using the SonarQube as tool for aggregation of all issues, bugs, vulnerabilities, coverage reports. GitHub CI should run all tests and necessary scripts automatically and add summary reports as a new comment of source PR.
An UML draft of this solution is here.
Now we are trying to cover Python and Java connectors only. But in the future this logic can be expanded for other languages and project components/modules.
The following files were updated for testing of issues and changes detections. Please ignore these because they will be reverted before merging of this PR.
You can see examples of generated reports into comments of this PR. This report is generated by our script and we can edit and format its template anytime if needed
This change is