-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SonarQube QA GitHub jobs #8668
SonarQube QA GitHub jobs #8668
Conversation
There is a doc topic on building the analytics based on test reports https://docs.sonarqube.org/latest/analysis/coverage/ So the goal for now is to generate reports into the temp dir and pass it to SonarQube. It should be really easy for python test formats. But may be a bit challenging if the default formatting is not supported or report format is not supported. |
Update unit tests. Code cleanup and fixes.
367772d
to
aaf49a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except https://github.com/airbytehq/airbyte/pull/8668/files#r776218491 comment. Please confirm this is not a typo before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main goals were implemented correctly. But there are several minor questions and comments.
At first we need to finish the "detection" logic. The SonarQube service can work and without reports.
What is a goal of the file airbyte-integrations/connectors/tasks.py ?
Can we move it to the "tools" folder?
tools/ci_static_check_reports/unit_tests/test_build_static_checkers_reports.py
Outdated
Show resolved
Hide resolved
Add changed module filter.
What
Playground for #7881
How
Work on generating the jobs reports and put it into SonarQube QA.