Normalization integration test #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristopheDuong
commented
Nov 10, 2020
...e-integrations/bases/standard-destination-test/src/main/resources/exchange_rate_catalog.json
Show resolved
Hide resolved
cgardens
reviewed
Nov 10, 2020
...ion-test/src/main/java/io/airbyte/integrations/standardtest/destination/TestDestination.java
Outdated
Show resolved
Hide resolved
…bytehq/airbyte into normalization
cgardens
approved these changes
Nov 10, 2020
| f"cast({MACRO_START} json_extract_scalar('{json_col}', {current}) {MACRO_END} as {MACRO_START} dbt_utils.type_int()" | ||
| + f" {MACRO_END}) as {MACRO_START} adapter.quote_as_configured('{name}', 'identifier') {MACRO_END}" | ||
| return "cast({} as {}) as {}".format( | ||
| jinja_call(f"json_extract_scalar('{json_col}', {current})"), |
There was a problem hiding this comment.
nice. so we didn't end up having to do anything integration specific in the dbt stuff. we were able to use the jinja macros!
There was a problem hiding this comment.
Yes, I had to write ugly DBT SQL (with macro everywhere) so it's the most generic possible and we handle destination specific in the DBT macros
michel-tricot
approved these changes
Nov 10, 2020
| @@ -1,7 +1,33 @@ | |||
| /* | |||
There was a problem hiding this comment.
How did it get in initially? Shouldn't have broke the build?
There was a problem hiding this comment.
it did. see https://github.com/airbytehq/airbyte/commits and 8c7129c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Enable normalization in destination integration tests
Here i remove the
_normalizedschema suffix but add it to the table name suffix instead until #845 defines proper_rawnaming for tables produced before normalization.There is also a method in
TestDestination.assertEquivalentMessagesthat needs to be better implemented since I didn't know how to properly compare expected messages and actual ones...(Messages from normalized tables contains a few extra metadata columns that fails the tests with
assertSameMessages){HKD: 13,2, date: 2020-11-01}vs
{emitted_at: 2020-11-01, HKD: 13,2, date: 2020-11-01, normalized_at: 2020-11-01, _exchange_hashid: 2141sfas21aaz2}