Add _raw suffix to non-normalized destination table names #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherifnada
requested review from
cgardens,
ChristopheDuong,
jrhizor and
michel-tricot
cgardens
approved these changes
Nov 10, 2020
There was a problem hiding this comment.
i know the goal is to get this in right now so feel free to skip this suggestion for now. but i think your life gets a whole lot easier if you just had a helper method that looks like this
public String getRawTableName(String streamName) {
return streamName + "_raw";
}
it saves us needing put "_raw" all over the codebase. ideally that string should be written in exactly one place. (at least in java)
maybe also a function that maps (rawTableName) => streamname.
anyway. go for it.
| @@ -35,6 +35,4 @@ quoting: | |||
| # are materialized, and more! | |||
| models: | |||
| airbyte: | |||
| # Schema (dataset) defined in profiles.yml is concatenated with schema below for dbt's final output | |||
There was a problem hiding this comment.
this suffixed the schema/dataset with _NORMALIZED
|
@cgardens good suggestion - implemented |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
_rawsuffix to all non-normalized table names in the destinationI'm pretty unhappy with this implementation and think we should remove it going forward, but putting it up to minimize delivery risk. Some better ways to do this are having DBT rename the raw tables in a pre-hook to add the _raw suffix, or having the destination integration output a "writtenCatalog" which contains the names of the tables it actually wrote. The latter is better in the case that we want to stop overwriting tables when performing full refresh syncs and instead write to a different table e.g
table_timestamp.