-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New connection page design #9025
Conversation
Addressed. |
: !["object", "array"].includes(typeof props.data.label) | ||
? props.data.label | ||
: `select_value_${props.data.value}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest we never try to attach the props.data.label
as a testid here. Since this is i18n, and we might want to run tests later against different or psuedo i18n, I think if testId
isn't specified we should directly fallback to the value instead, and use something like lodash's camelCase
to make sure we're getting rid of spaces in it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's exactly the reason why I added this logic. By default, we were setting data-testid to label, so if we change it right now to value - it will break some e2e tests.
Should we open separate task for it? Or should I fix it as part of this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's push it into a separate PR. We could potentially also just enforce a testid for all input if we anyway do it in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this on Chrome Linux. Functionality wise seems to work. I've mostly have minor concerns around design and code left, but we should not block this PR now on this, and fix them afterwards. So LGTM for me to merge.
What
Includes a bunch of improvements for Connection Form:
Batch Edit
![image](https://user-images.githubusercontent.com/3767150/153867262-289ff20c-9494-44ce-8470-87dea6e7a817.png)
New Connection Form UI
Move transformation to separate tab
![image](https://user-images.githubusercontent.com/3767150/153478145-ab3fe01a-ddbf-48c9-9859-5c5929f66a77.png)
Set 24h sync by default Closes set "Every 24 hours" as the default sync frequency #9733
Closes #9728
Closes #9729
Closes #4226
Closes #9462
What is left:
PathPopout
( primary key and cursor field )Recommended reading order
ConnectionForm.tsx
CollapsibleCard.tsx
FormCard.tsx
services/BulkEdit/BulkEditService.tsx
BulkEditHeader.tsx
PathPopout.tsx
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)