Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 Destination DynamoDB: rename dynamodb_table_name to dynamodb_table_name_prefix #9314

Merged
merged 6 commits into from
Jan 13, 2022
Merged

🎉 Destination DynamoDB: rename dynamodb_table_name to dynamodb_table_name_prefix #9314

merged 6 commits into from
Jan 13, 2022

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Jan 5, 2022 •
edited
Loading

What

In DynamoDB connector spec, the field dynamodb_table_name is in fact used as a prefix to name the output table.
This is misleading for connector users as mentioned on Slack.

How

Rename dynamodb_table_name to dynamodb_table_name_prefix and related code occurrences.

Recommended reading order

  1. airbyte-integrations/connectors/destination-dynamodb/src/main/resources/spec.json
  2. *.java

🚨 User Impact 🚨

None

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jan 5, 2022
@alafanechere alafanechere force-pushed the augustin/dynamodb-table-name-prefix branch from 4469712 to d37ea4a Compare January 5, 2022 15:50
@alafanechere alafanechere temporarily deployed to more-secrets January 5, 2022 15:52 Inactive
@alafanechere alafanechere marked this pull request as ready for review January 5, 2022 15:53
@alafanechere alafanechere added the type/enhancement New feature or request label Jan 5, 2022
@jrhizor jrhizor temporarily deployed to more-secrets January 5, 2022 15:55 Inactive
@alafanechere
Copy link
Contributor Author

alafanechere commented Jan 11, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/destination-dynamodb

🕑 connectors/destination-dynamodb https://github.com/airbytehq/airbyte/actions/runs/1684066961
✅ connectors/destination-dynamodb https://github.com/airbytehq/airbyte/actions/runs/1684066961
No Python unittests run

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 11, 2022 18:45 Inactive
@alafanechere
Copy link
Contributor Author

@misteryeo / @sherifnada do you mind taking a look as I modified the specs for this connector.

alafanechere and others added 2 commits January 12, 2022 09:46
@alafanechere @sherifnada
Update airbyte-integrations/connectors/destination-dynamodb/src/main/…
291da87 
…resources/spec.json

Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
@alafanechere @sherifnada
Update airbyte-integrations/connectors/destination-dynamodb/src/main/…
ddc43f1 
…resources/spec.json

Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
@alafanechere
Copy link
Contributor Author

alafanechere commented Jan 12, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/destination-dynamodb

🕑 connectors/destination-dynamodb https://github.com/airbytehq/airbyte/actions/runs/1686687252
✅ connectors/destination-dynamodb https://github.com/airbytehq/airbyte/actions/runs/1686687252
No Python unittests run

@alafanechere alafanechere temporarily deployed to more-secrets January 12, 2022 08:48 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 12, 2022 08:49 Inactive
@alafanechere
Copy link
Contributor Author

alafanechere commented Jan 12, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-dynamodb

🕑 connectors/destination-dynamodb https://github.com/airbytehq/airbyte/actions/runs/1686766019
✅ connectors/destination-dynamodb https://github.com/airbytehq/airbyte/actions/runs/1686766019

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 12, 2022 09:08 Inactive
@alafanechere alafanechere temporarily deployed to more-secrets January 12, 2022 18:05 Inactive
marcosmarxm
marcosmarxm approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @alafanechere

@alafanechere alafanechere temporarily deployed to more-secrets January 13, 2022 07:48 Inactive
@alafanechere alafanechere temporarily deployed to more-secrets January 13, 2022 09:02 Inactive
@alafanechere alafanechere merged commit 71f5b1c into master Jan 13, 2022
@alafanechere alafanechere deleted the augustin/dynamodb-table-name-prefix branch January 13, 2022 18:15
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jan 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherifnada sherifnada sherifnada approved these changes

@marcosmarxm marcosmarxm marcosmarxm approved these changes

@misteryeo misteryeo Awaiting requested review from misteryeo

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/dynamodb connectors/destinations-database type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alafanechere @marcosmarxm @sherifnada @jrhizor @karinakuz @octavia-squidington-iii