improve byte buffer handling #9331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
|
This definitely looks like the way to go, muuuuch cleaner, thanks! |
pmossman
approved these changes
Jan 6, 2022
pmossman
pushed a commit
that referenced
this pull request
Jan 7, 2022
pmossman
pushed a commit
that referenced
this pull request
Jan 11, 2022
pmossman
added a commit
that referenced
this pull request
Jan 11, 2022
…summary metadata (#9327) * StateDeltaTracker class and tests * working prototype implementation of per-stream record tracking * misc stuff to get build working * add new fields to replicationAttemptSummary * update AirbyteMessageTracker to use StateDeltaTracker, and new interface methods * finish implementation and tests for stateDeltaTracker and all new ReplicationAttemptSummary fields * undo temporary changes to files that I accidentally committed * simplify interactions with byte buffers (#9331) * define a map instead of generic object for counts by stream * follow convention of keyToValue instead of valueByKey for maps * use synchronized blocks instead of synchronized methods * add totalBytesEmitted field to eventually replace bytesSynced * misc PR feedback nits * additionalProperties probably should still be false * javadoc formatting * define syncStats and use it for total and per-stream stats * change per-stream stats map to a list, and set stats in standardSyncSummary * wrap entire method bodies in synchronized block * use a long instead of a Long for required fields * remove extranneous 'this' * set committed records to emitted records if sync has success status * throw checked exception if commit state before add state, simplify exception handling throughout * set delta tracker memory limit to 20MiB * log error message that was thrown instead of assumed cause * StreamSyncStats wrapper, add test case for populating stats on failure, misc formatting Co-authored-by: Charles <giardina.charles@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
ByteBuffertends to be a lot simpler. I think you ended up trying to useByteBuffersto insert and read out ofbyte[], but if you just wrap thebyte[]you want to interact with, I think it gets way easier. I double checked that tests still pass. Definitely happy to discuss more if it's not clear!