Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build #9344

Merged
merged 3 commits into from
Jan 6, 2022
Merged

Fix build #9344

merged 3 commits into from
Jan 6, 2022

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Jan 6, 2022 •
edited
Loading

What

  • reformat
  • fix bad merge

CI build is unhappy, but pretty sure it's all fine:

  • missing docker image will be fixed by publishing normalization (in another PR)
  • connectors base build failure was transient (disk space)
  • platform build looks unrelated (something about health check returning null)

@edgao edgao temporarily deployed to more-secrets January 6, 2022 18:38 Inactive
@github-actions github-actions bot added area/platform issues related to the platform area/worker Related to worker labels Jan 6, 2022
@edgao edgao temporarily deployed to more-secrets January 6, 2022 18:48 Inactive
@edgao edgao requested a review from marcosmarxm January 6, 2022 19:00
@edgao edgao temporarily deployed to more-secrets January 6, 2022 19:10 Inactive
@edgao
Copy link
Contributor Author

edgao commented Jan 6, 2022

gonna merge this just to get our builds working again, but please take a look when you have a chance!

@edgao edgao merged commit 80695ad into master Jan 6, 2022
@edgao edgao deleted the edgao/fixes branch January 6, 2022 19:23
@jrhizor jrhizor mentioned this pull request Jan 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmarxm marcosmarxm Awaiting requested review from marcosmarxm

Assignees
No one assigned
Labels
area/platform issues related to the platform area/worker Related to worker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@edgao