Destination Snowflake add test to avoid duplicated staged data #9412

VitaliiMaltsev · 2022-01-11T15:51:24Z

What

Add test for #9141

🚨 User Impact 🚨

None user impact

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed.

CLAassistant · 2022-01-11T15:51:33Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

vmaltsev seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

VitaliiMaltsev · 2022-01-11T15:52:57Z

/test connector=connectors/destination-snowflake

🕑 connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1683349529
✅ connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1683349529
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    13      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     155      8    95%
	 normalization/transform_catalog/reserved_keywords.py                 13      0   100%
	 normalization/transform_catalog/stream_processor.py                 520    333    36%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         148     34    77%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1258    525    58%

edgao

two questions, but overall LGTM

edgao · 2022-01-11T19:27:01Z

...ke/src/test/java/io/airbyte/integrations/destination/snowflake/SnowflakeDestinationTest.java

+    }
+
+    try {
+      airbyteMessageConsumer.close();


can this use assertThrows(...)?

can this use assertThrows(...)?

replaced with assertThrows

edgao · 2022-01-11T19:27:39Z

...ke/src/test/java/io/airbyte/integrations/destination/snowflake/SnowflakeDestinationTest.java

+
+    try {
+      airbyteMessageConsumer.close();
+    }catch (Exception e){


does this need to catch all exception, or can it only catch SQLException? (in retrospect, same question here https://github.com/airbytehq/airbyte/pull/9141/files#diff-33bfb48d5bb53941a89b564d1e0819ad2a78ef0c19dcb169d568e2205a19959aR181 )

does this need to catch all exception, or can it only catch SQLException? (in retrospect, same question here https://github.com/airbytehq/airbyte/pull/9141/files#diff-33bfb48d5bb53941a89b564d1e0819ad2a78ef0c19dcb169d568e2205a19959aR181 )

really good question. I believe SQLException should be enough

vmaltsev added 19 commits December 15, 2021 10:45

fix for jdk 17

93d53ac

Merge branch 'master' of github.com:airbytehq/airbyte

ede8d38

Merge branch 'master' of github.com:airbytehq/airbyte

27be3fe

Merge branch 'master' of github.com:airbytehq/airbyte

ca75033

Merge branch 'master' of github.com:airbytehq/airbyte

72ab46f

Merge branch 'master' of github.com:airbytehq/airbyte

aec3384

Merge branch 'master' of github.com:airbytehq/airbyte

7efd5aa

Merge branch 'master' of github.com:airbytehq/airbyte

6a773f9

Merge branch 'master' of github.com:airbytehq/airbyte

fa18537

Merge branch 'master' of github.com:airbytehq/airbyte

b0ba37b

Merge branch 'master' of github.com:airbytehq/airbyte

fa31a0d

Merge branch 'master' of github.com:airbytehq/airbyte

67e0bd6

Merge branch 'master' of github.com:airbytehq/airbyte

ec0d1bd

Merge branch 'master' of github.com:airbytehq/airbyte

23598ec

Merge branch 'master' of github.com:airbytehq/airbyte

59d63e6

Merge branch 'master' of github.com:airbytehq/airbyte

e2cb62c

Merge branch 'master' of github.com:airbytehq/airbyte

632583a

Merge branch 'master' of github.com:airbytehq/airbyte

2bc76ce

added unit test

78f4d29

VitaliiMaltsev temporarily deployed to more-secrets January 11, 2022 15:51 Inactive

github-actions bot added the area/connectors Connector related issues label Jan 11, 2022

VitaliiMaltsev requested a review from edgao January 11, 2022 15:52

octavia-squidington-iii temporarily deployed to more-secrets January 11, 2022 15:55 Inactive

edgao requested changes Jan 11, 2022

View reviewed changes

refactoring

603e4ac

VitaliiMaltsev temporarily deployed to more-secrets January 12, 2022 09:33 Inactive

replace Exception with SQLException

b816c5a

VitaliiMaltsev temporarily deployed to more-secrets January 12, 2022 10:25 Inactive

VitaliiMaltsev requested a review from edgao January 12, 2022 10:27

edgao approved these changes Jan 12, 2022

View reviewed changes

VitaliiMaltsev linked an issue Jan 12, 2022 that may be closed by this pull request

Destination Snowflake: add test to avoid duplicated staging data #9389

Closed

VitaliiMaltsev merged commit 5383439 into master Jan 12, 2022

VitaliiMaltsev deleted the vmaltsev/9389-destination-snowflake-add-test-avoid-duplicates branch January 12, 2022 17:03

octavia-squidington-iii mentioned this pull request Jan 13, 2022

Bump Airbyte version from 0.35.5-alpha to 0.35.6-alpha #9483

Closed

karinakuz added connectors/destinations-warehouse connectors/destination/snowflake labels Jan 17, 2022

octavia-squidington-iii mentioned this pull request Jan 20, 2022

Bump Airbyte version from 0.35.5-alpha to 0.35.6-alpha #9630

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Destination Snowflake add test to avoid duplicated staged data #9412

Destination Snowflake add test to avoid duplicated staged data #9412

VitaliiMaltsev commented Jan 11, 2022

CLAassistant commented Jan 11, 2022

VitaliiMaltsev commented Jan 11, 2022 •

edited by github-actions bot

Loading

edgao left a comment

edgao Jan 11, 2022

VitaliiMaltsev Jan 12, 2022

edgao Jan 11, 2022

VitaliiMaltsev Jan 12, 2022

Destination Snowflake add test to avoid duplicated staged data #9412

Destination Snowflake add test to avoid duplicated staged data #9412

Conversation

VitaliiMaltsev commented Jan 11, 2022

What

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

CLAassistant commented Jan 11, 2022

VitaliiMaltsev commented Jan 11, 2022 • edited by github-actions bot Loading

edgao left a comment

Choose a reason for hiding this comment

edgao Jan 11, 2022

Choose a reason for hiding this comment

VitaliiMaltsev Jan 12, 2022

Choose a reason for hiding this comment

edgao Jan 11, 2022

Choose a reason for hiding this comment

VitaliiMaltsev Jan 12, 2022

Choose a reason for hiding this comment

VitaliiMaltsev commented Jan 11, 2022 •

edited by github-actions bot

Loading