Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workspaceId to intercom custom attributes #9489

Merged
merged 2 commits into from
Jan 13, 2022
Merged

Add workspaceId to intercom custom attributes #9489

merged 2 commits into from
Jan 13, 2022

Conversation

jamakase
Copy link
Contributor

@jamakase jamakase commented Jan 13, 2022 •
edited
Loading

What

Adds workspace_id to intercom custom attributes

@jamakase jamakase requested a review from jrhizor January 13, 2022 20:32
@github-actions github-actions bot added area/frontend area/platform issues related to the platform labels Jan 13, 2022
@jamakase jamakase requested a review from nataliekwong January 13, 2022 20:42
@jamakase jamakase temporarily deployed to more-secrets January 13, 2022 20:44 Inactive
@jamakase jamakase temporarily deployed to more-secrets January 13, 2022 22:52 Inactive
@jamakase jamakase merged commit 5f4a5bb into master Jan 13, 2022
@jamakase jamakase deleted the jamakase/add-workpsace-id-intercom branch January 13, 2022 23:07
@nataliekwong
Copy link
Contributor

@jamakase I see an error in the branch being deployed - does that block it from being merged?

@jamakase
Copy link
Contributor Author

@nataliekwong TBH I am not sure what this deployed error is for. As I remember guys are deploying UI to the cloud manually via new release.

@davinchia am I right?

@davinchia
Copy link
Contributor

yeap! this will be the in the next release and pulled in once we deploy to Cloud. @nataliekwong is it urgent to get this out?

@nataliekwong
Copy link
Contributor

We need the workspace ID surfaced in order to launch product tours (since Intercom needs to show the product tour for a given URL, and the workspace ID is now in the URL). When do you expect the next release to be? If it's in the early part of this week / next few days, I'm fine with waiting. @davinchia

@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jan 20, 2022
Merged
@nataliekwong nataliekwong mentioned this pull request Jan 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nataliekwong nataliekwong nataliekwong approved these changes

@jrhizor jrhizor jrhizor approved these changes

Assignees
No one assigned
Labels
area/platform issues related to the platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jamakase @nataliekwong @davinchia @jrhizor