🐛 Source Github: Remove optional parameter `Accept` for reaction's streams to fix error with `502` HTTP status code #9492

yevhenii-ldv · 2022-01-13T22:47:02Z

What

This PR is intended to fix the problem that arises in the https://github.com/airbytehq/oncall/issues/75 task. Unfortunately, I was never able to reproduce the error that appears in the user, however, I found an article on the Github forum that 502 errors sometimes appear due to the Assert header, so I removed it, after checking the data for identity with and without this header him..

How

Remove Accept header for Reaction's streams

Pre-merge Checklist

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

This change is

…s to fix error with 502 HTTP status code

…urochkin/fix-github-502-error-for-streams-with-reactions

yevhenii-ldv · 2022-01-13T22:48:22Z

/test connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/1695201796
✅ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/1695201796
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      6    92%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38      0   100%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     17    69%
	 source_acceptance_test/utils/compare.py                 62     23    63%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  979    404    59%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                        Stmts   Miss  Cover
	 -----------------------------------------------
	 source_github/__init__.py       2      0   100%
	 source_github/source.py        76     34    55%
	 source_github/streams.py      363    162    55%
	 -----------------------------------------------
	 TOTAL                         441    196    56%

yevhenii-ldv · 2022-01-17T08:08:27Z

/test connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/1706893614
❌ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/1706893614
🐛 https://scans.gradle.com/s/lgffn2bymrjdo
Python short test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contai...
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
======================== 4 failed, 12 passed in 21.86s =========================

airbyte-integrations/connectors/source-github/source_github/streams.py

Zirochkaa · 2022-01-17T12:20:47Z

Please use template from .github/PULL_REQUEST_TEMPLATE/bug-fix_template.md file for PR description because this is a bug fix.

yevhenii-ldv · 2022-01-17T12:22:29Z

/test connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/1707917869
✅ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/1707917869
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      6    92%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38      0   100%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     17    69%
	 source_acceptance_test/utils/compare.py                 62     23    63%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  979    404    59%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                        Stmts   Miss  Cover
	 -----------------------------------------------
	 source_github/__init__.py       2      0   100%
	 source_github/source.py        76     34    55%
	 source_github/streams.py      366    162    56%
	 -----------------------------------------------
	 TOTAL                         444    196    56%

…urochkin/fix-github-502-error-for-streams-with-reactions

yevhenii-ldv · 2022-01-17T12:59:52Z

/publish connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/1708057315
❌ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/1708057315

yevhenii-ldv · 2022-01-17T13:08:39Z

/publish connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/1708093666
✅ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/1708093666

Source Github: Remove optional parameter Accept for reaction's stream…

c53ff74

…s to fix error with 502 HTTP status code

github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jan 13, 2022

Merge branch 'master' of https://github.com/airbytehq/airbyte into yk…

a16a761

…urochkin/fix-github-502-error-for-streams-with-reactions

yevhenii-ldv temporarily deployed to more-secrets January 13, 2022 22:50 Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 13, 2022 22:50 Inactive

yevhenii-ldv requested review from Zirochkaa, htrueman and sergei-solonitcyn January 13, 2022 22:59

htrueman approved these changes Jan 14, 2022

View reviewed changes

add logger for rate limit handler

2cf4b26

yevhenii-ldv temporarily deployed to more-secrets January 17, 2022 08:09 Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 17, 2022 08:11 Inactive

Zirochkaa reviewed Jan 17, 2022

View reviewed changes

airbyte-integrations/connectors/source-github/source_github/streams.py Outdated Show resolved Hide resolved

fix mistake

a115b01

yevhenii-ldv temporarily deployed to more-secrets January 17, 2022 12:23 Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 17, 2022 12:24 Inactive

Zirochkaa approved these changes Jan 17, 2022

View reviewed changes

yevhenii-ldv added 2 commits January 17, 2022 14:56

Merge branch 'master' of https://github.com/airbytehq/airbyte into yk…

905fd49

…urochkin/fix-github-502-error-for-streams-with-reactions

update changelogs

1202c80

yevhenii-ldv temporarily deployed to more-secrets January 17, 2022 13:00 Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 17, 2022 13:02 Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 17, 2022 13:10 Inactive

update version

9657a1c

yevhenii-ldv merged commit cb6d9ab into master Jan 17, 2022

yevhenii-ldv deleted the ykurochkin/fix-github-502-error-for-streams-with-reactions branch January 17, 2022 13:21

yevhenii-ldv temporarily deployed to more-secrets January 17, 2022 13:22 Inactive

octavia-squidington-iii mentioned this pull request Jan 20, 2022

Bump Airbyte version from 0.35.5-alpha to 0.35.6-alpha #9630

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Source Github: Remove optional parameter `Accept` for reaction's streams to fix error with `502` HTTP status code #9492

🐛 Source Github: Remove optional parameter `Accept` for reaction's streams to fix error with `502` HTTP status code #9492

yevhenii-ldv commented Jan 13, 2022 •

edited by pmossman

Loading

yevhenii-ldv commented Jan 13, 2022 •

edited by github-actions bot

Loading

yevhenii-ldv commented Jan 17, 2022 •

edited by github-actions bot

Loading

Zirochkaa commented Jan 17, 2022

yevhenii-ldv commented Jan 17, 2022 •

edited by github-actions bot

Loading

yevhenii-ldv commented Jan 17, 2022 •

edited by github-actions bot

Loading

yevhenii-ldv commented Jan 17, 2022 •

edited by github-actions bot

Loading

🐛 Source Github: Remove optional parameter Accept for reaction's streams to fix error with 502 HTTP status code #9492

🐛 Source Github: Remove optional parameter Accept for reaction's streams to fix error with 502 HTTP status code #9492

Conversation

yevhenii-ldv commented Jan 13, 2022 • edited by pmossman Loading

What

How

Recommended reading order

Pre-merge Checklist

Community member or Airbyter

Airbyter

yevhenii-ldv commented Jan 13, 2022 • edited by github-actions bot Loading

yevhenii-ldv commented Jan 17, 2022 • edited by github-actions bot Loading

Zirochkaa commented Jan 17, 2022

yevhenii-ldv commented Jan 17, 2022 • edited by github-actions bot Loading

yevhenii-ldv commented Jan 17, 2022 • edited by github-actions bot Loading

yevhenii-ldv commented Jan 17, 2022 • edited by github-actions bot Loading

🐛 Source Github: Remove optional parameter `Accept` for reaction's streams to fix error with `502` HTTP status code #9492

🐛 Source Github: Remove optional parameter `Accept` for reaction's streams to fix error with `502` HTTP status code #9492

yevhenii-ldv commented Jan 13, 2022 •

edited by pmossman

Loading

yevhenii-ldv commented Jan 13, 2022 •

edited by github-actions bot

Loading

yevhenii-ldv commented Jan 17, 2022 •

edited by github-actions bot

Loading

yevhenii-ldv commented Jan 17, 2022 •

edited by github-actions bot

Loading

yevhenii-ldv commented Jan 17, 2022 •

edited by github-actions bot

Loading

yevhenii-ldv commented Jan 17, 2022 •

edited by github-actions bot

Loading