-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 SurveyMonkey source: scopes change #9508
Conversation
/test connector=connectors/source-surveymonkey
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to change something inside of Oauth part of java side for this connector, in terms of scopes?
@bazarnov no, we needn't pass scopes to receive access_token for oAuth. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@annalvova05 , Please publish your changes
/publish connector=connectors/source-surveymonkey
|
What
We need to remove the scopes we do not use from the SurveyMonkey connector. This is the requirement from the support team to make our App Public.
How
Change
check
method for the connector.Recommended reading order
source.py
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereThis change is