-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Intercom: Fix handling of scroll param when it expired #9513
🐛 Source Intercom: Fix handling of scroll param when it expired #9513
Conversation
airbyte-integrations/connectors/source-intercom/source_intercom/source.py
Outdated
Show resolved
Hide resolved
/test connector=connectors/source-intercom
|
airbyte-integrations/connectors/source-intercom/source_intercom/source.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lazebnyi , please publish your changes
/test connector=connectors/source-intercom
|
/test connector=connectors/source-intercom
|
/publish connector=connectors/source-intercom
|
What
If the scroll isn't used for 1 minute, it expires and calls with that scroll param will fail.
How
Working in the same way as if scroll param is already existed (PR)
Recommended reading order
x.java
y.python
Pre-merge Checklist
Updating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereThis change is