Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Intercom: Fix handling of scroll param when it expired #9513

Merged

Conversation

lazebnyi
Copy link
Collaborator

@lazebnyi lazebnyi commented Jan 14, 2022

What

If the scroll isn't used for 1 minute, it expires and calls with that scroll param will fail.

How

Working in the same way as if scroll param is already existed (PR)

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here


This change is Reviewable

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jan 14, 2022
@lazebnyi lazebnyi temporarily deployed to more-secrets January 14, 2022 13:02 Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets January 14, 2022 13:20 Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets January 14, 2022 16:56 Inactive
@lazebnyi lazebnyi requested a review from antixar January 17, 2022 15:45
@lazebnyi lazebnyi temporarily deployed to more-secrets January 17, 2022 15:46 Inactive
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Jan 17, 2022

/test connector=connectors/source-intercom

🕑 connectors/source-intercom https://github.com/airbytehq/airbyte/actions/runs/1708780416
❌ connectors/source-intercom https://github.com/airbytehq/airbyte/actions/runs/1708780416
🐛 https://scans.gradle.com/s/w2ybv44kdibzw

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 17, 2022 15:49 Inactive
@lazebnyi lazebnyi requested a review from antixar January 18, 2022 13:33
Copy link
Contributor

@antixar antixar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lazebnyi , please publish your changes

@lazebnyi lazebnyi removed the request for review from midavadim January 19, 2022 09:57
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Jan 19, 2022

/test connector=connectors/source-intercom

🕑 connectors/source-intercom https://github.com/airbytehq/airbyte/actions/runs/1717340135
❌ connectors/source-intercom https://github.com/airbytehq/airbyte/actions/runs/1717340135
🐛 https://gradle.com/s/gx2upjo4urcjm

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 19, 2022 10:00 Inactive
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Jan 19, 2022

/test connector=connectors/source-intercom

🕑 connectors/source-intercom https://github.com/airbytehq/airbyte/actions/runs/1718008584
✅ connectors/source-intercom https://github.com/airbytehq/airbyte/actions/runs/1718008584
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      6    92%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38      0   100%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     17    69%
	 source_acceptance_test/utils/compare.py                 62     23    63%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  979    404    59%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                          Stmts   Miss  Cover
	 -------------------------------------------------
	 source_intercom/__init__.py       2      0   100%
	 source_intercom/source.py       218     42    81%
	 -------------------------------------------------
	 TOTAL                           220     42    81%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                          Stmts   Miss  Cover
	 -------------------------------------------------
	 source_intercom/__init__.py       2      0   100%
	 source_intercom/source.py       218     56    74%
	 -------------------------------------------------
	 TOTAL                           220     56    75%

@lazebnyi lazebnyi marked this pull request as ready for review January 19, 2022 12:39
@lazebnyi lazebnyi temporarily deployed to more-secrets January 19, 2022 12:40 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 19, 2022 12:41 Inactive
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Jan 19, 2022

/publish connector=connectors/source-intercom

🕑 connectors/source-intercom https://github.com/airbytehq/airbyte/actions/runs/1718067645
✅ connectors/source-intercom https://github.com/airbytehq/airbyte/actions/runs/1718067645

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 19, 2022 12:57 Inactive
@lazebnyi lazebnyi merged commit 6990cc7 into master Jan 19, 2022
@lazebnyi lazebnyi deleted the lazebnyi/9339-fix-intercom-handaling-404-companies-error branch January 19, 2022 13:26
@lazebnyi lazebnyi temporarily deployed to more-secrets January 19, 2022 13:28 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Source Intercom: company_segment raises 404 error while calling n+1 companies stream.
4 participants