Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snowflake source: keep session alive to avoid breaking connection #9567

Merged

Conversation

sashaNeshcheret
Copy link
Contributor

@sashaNeshcheret sashaNeshcheret commented Jan 18, 2022

What

After 6 hours of sync we got 403 error from snowflake.

How

Added parameter CLIENT_SESSION_KEEP_ALIVE to avoid breaking connection before it closing

Recommended reading order

  1. x.java

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added the area/connectors Connector related issues label Jan 18, 2022
@sashaNeshcheret
Copy link
Contributor Author

sashaNeshcheret commented Jan 18, 2022

/test connector=connectors/source-snowflake

🕑 connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/1712213231
✅ connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/1712213231
No Python unittests run

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 18, 2022 10:28 Inactive
@sashaNeshcheret sashaNeshcheret linked an issue Jan 18, 2022 that may be closed by this pull request
Copy link
Contributor

@alexandertsukanov alexandertsukanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sashaNeshcheret sashaNeshcheret temporarily deployed to more-secrets January 19, 2022 11:38 Inactive
Copy link
Contributor

@alexandr-shegeda alexandr-shegeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. we can proceed with publishing and merging without airbyte review

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Jan 19, 2022
@sashaNeshcheret
Copy link
Contributor Author

sashaNeshcheret commented Jan 19, 2022

/publish connector=connectors/source-snowflake

🕑 connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/1718001399
✅ connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/1718001399

@sashaNeshcheret sashaNeshcheret temporarily deployed to more-secrets January 19, 2022 12:38 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 19, 2022 12:39 Inactive
@sashaNeshcheret sashaNeshcheret temporarily deployed to more-secrets January 19, 2022 13:02 Inactive
@sashaNeshcheret sashaNeshcheret merged commit 89308f7 into master Jan 19, 2022
@sashaNeshcheret sashaNeshcheret deleted the omneshcheret/6246-snowflake-error-fetching-chunk branch January 19, 2022 13:09
@harshild
Copy link

Looks like this was fixed a while back, but our team is facing the same issue with snowflake source connector version 0.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error fetching chunk from Snowflake
6 participants