🐛 Source Salesforce: parse CSV with "unix" dialect #9757

grubberr · 2022-01-24T15:56:37Z

Signed-off-by: Sergey Chvalyuk grubberr@gmail.com

What

Incoming CSV data looks like formatted using "unix" dialect. We need to parse it more appropriate way.
It can also help to fix this problem https://github.com/airbytehq/oncall/issues/115

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

codecov · 2022-01-24T16:05:16Z

Codecov Report

❗ No coverage uploaded for pull request base (master@579923d). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #9757   +/-   ##
=========================================
  Coverage          ?   74.45%           
=========================================
  Files             ?        7           
  Lines             ?      458           
  Branches          ?        0           
=========================================
  Hits              ?      341           
  Misses            ?      117           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 579923d...901cc7c. Read the comment docs.

grubberr · 2022-01-24T16:06:41Z

/test connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1740860159
❌ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1740860159
🐛 https://gradle.com/s/ygpoqoatuzvma
Python short test summary info:

=========================== short test summary info ============================
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
=================== 1 failed, 15 passed in 146.60s (0:02:26) ===================

grubberr · 2022-01-24T16:33:00Z

/test connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1740990997
✅ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1740990997
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      6    92%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38      0   100%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     17    69%
	 source_acceptance_test/utils/compare.py                 62     23    63%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  979    404    59%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                 Stmts   Miss  Cover
	 --------------------------------------------------------
	 source_salesforce/__init__.py            2      0   100%
	 source_salesforce/api.py               126     32    75%
	 source_salesforce/exceptions.py          1      0   100%
	 source_salesforce/rate_limiting.py      22      6    73%
	 source_salesforce/source.py             60     20    67%
	 source_salesforce/streams.py           239    143    40%
	 source_salesforce/utils.py               8      7    12%
	 --------------------------------------------------------
	 TOTAL                                  458    208    55%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                 Stmts   Miss  Cover
	 --------------------------------------------------------
	 source_salesforce/__init__.py            2      0   100%
	 source_salesforce/api.py               126     44    65%
	 source_salesforce/exceptions.py          1      0   100%
	 source_salesforce/rate_limiting.py      22      6    73%
	 source_salesforce/source.py             60     25    58%
	 source_salesforce/streams.py           239     42    82%
	 source_salesforce/utils.py               8      0   100%
	 --------------------------------------------------------
	 TOTAL                                  458    117    74%

antixar

Could you add an unit test for this case?
Please fill the PR checklist

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-01-25T15:39:19Z

/test connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1746281501
✅ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1746281501
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      6    92%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38      0   100%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     17    69%
	 source_acceptance_test/utils/compare.py                 62     23    63%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  979    404    59%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                 Stmts   Miss  Cover
	 --------------------------------------------------------
	 source_salesforce/__init__.py            2      0   100%
	 source_salesforce/api.py               126     32    75%
	 source_salesforce/exceptions.py          1      0   100%
	 source_salesforce/rate_limiting.py      22      6    73%
	 source_salesforce/source.py             60     20    67%
	 source_salesforce/streams.py           239    143    40%
	 source_salesforce/utils.py               8      7    12%
	 --------------------------------------------------------
	 TOTAL                                  458    208    55%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                 Stmts   Miss  Cover
	 --------------------------------------------------------
	 source_salesforce/__init__.py            2      0   100%
	 source_salesforce/api.py               126     44    65%
	 source_salesforce/exceptions.py          1      0   100%
	 source_salesforce/rate_limiting.py      22      6    73%
	 source_salesforce/source.py             60     25    58%
	 source_salesforce/streams.py           239     42    82%
	 source_salesforce/utils.py               8      0   100%
	 --------------------------------------------------------
	 TOTAL                                  458    117    74%

antixar

LGTM
Please publish your changes

grubberr · 2022-01-25T17:02:45Z

/publish connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1746690062
✅ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1746690062

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

improve csv parsing

4fad0f3

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

github-actions bot added the area/connectors Connector related issues label Jan 24, 2022

grubberr temporarily deployed to more-secrets January 24, 2022 15:58 Inactive

grubberr changed the title ~~improve csv parsing~~ 🐛 Source Salesforce: parse CSV with "unix" dialect Jan 24, 2022

grubberr self-assigned this Jan 24, 2022

bump version 0.1.18 -> 0.1.19

00d8d58

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

github-actions bot added the area/documentation Improvements or additions to documentation label Jan 24, 2022

grubberr temporarily deployed to more-secrets January 24, 2022 16:07 Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 24, 2022 16:09 Inactive

grubberr requested a review from midavadim January 24, 2022 16:09

octavia-squidington-iii temporarily deployed to more-secrets January 24, 2022 16:35 Inactive

grubberr requested a review from antixar January 24, 2022 16:55

antixar reviewed Jan 25, 2022

View reviewed changes

Merge branch 'master' into grubberr/oncall-115-improve-csv-parsing

48530bd

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr temporarily deployed to more-secrets January 25, 2022 14:46 Inactive

test_csv_reader_dialect_unix added

901cc7c

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr requested a review from antixar January 25, 2022 15:41

grubberr temporarily deployed to more-secrets January 25, 2022 15:41 Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 25, 2022 15:41 Inactive

antixar approved these changes Jan 25, 2022

View reviewed changes

octavia-squidington-iii temporarily deployed to more-secrets January 25, 2022 17:05 Inactive

source_specs.yaml updated

fc1d1ce

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr merged commit 2629098 into master Jan 25, 2022

grubberr deleted the grubberr/oncall-115-improve-csv-parsing branch January 25, 2022 17:27

grubberr temporarily deployed to more-secrets January 25, 2022 17:27 Inactive

This was referenced Jan 25, 2022

Bump Airbyte version from 0.35.9-alpha to 0.35.10-alpha #9798

Closed

Bump Airbyte version from 0.35.9-alpha to 0.35.10-alpha #9800

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Source Salesforce: parse CSV with "unix" dialect #9757

🐛 Source Salesforce: parse CSV with "unix" dialect #9757

grubberr commented Jan 24, 2022 •

edited

Loading

codecov bot commented Jan 24, 2022 •

edited

Loading

grubberr commented Jan 24, 2022 •

edited by github-actions bot

Loading

grubberr commented Jan 24, 2022 •

edited by github-actions bot

Loading

antixar left a comment

grubberr commented Jan 25, 2022 •

edited by github-actions bot

Loading

antixar left a comment

grubberr commented Jan 25, 2022 •

edited by github-actions bot

Loading

🐛 Source Salesforce: parse CSV with "unix" dialect #9757

🐛 Source Salesforce: parse CSV with "unix" dialect #9757

Conversation

grubberr commented Jan 24, 2022 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

codecov bot commented Jan 24, 2022 • edited Loading

Codecov Report

grubberr commented Jan 24, 2022 • edited by github-actions bot Loading

grubberr commented Jan 24, 2022 • edited by github-actions bot Loading

antixar left a comment

Choose a reason for hiding this comment

grubberr commented Jan 25, 2022 • edited by github-actions bot Loading

antixar left a comment

Choose a reason for hiding this comment

grubberr commented Jan 25, 2022 • edited by github-actions bot Loading

grubberr commented Jan 24, 2022 •

edited

Loading

codecov bot commented Jan 24, 2022 •

edited

Loading

grubberr commented Jan 24, 2022 •

edited by github-actions bot

Loading

grubberr commented Jan 24, 2022 •

edited by github-actions bot

Loading

grubberr commented Jan 25, 2022 •

edited by github-actions bot

Loading

grubberr commented Jan 25, 2022 •

edited by github-actions bot

Loading