feat: add optional rbac.secrets value to give GET/LIST/WATCH on Secrets
#790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashokkumar-srinivas
changed the title
ashokkumar-srinivas
force-pushed
the
airflow-secrets-role
branch
from
f9858ba
to
d9a3a19
Compare
Signed-off-by: Ashok Kumar Srinivas <94833956+ashsrinivas-deloitte@users.noreply.github.com>
…ow ns Signed-off-by: Ashok Kumar Srinivas <94833956+ashsrinivas-deloitte@users.noreply.github.com>
ashokkumar-srinivas
force-pushed
the
airflow-secrets-role
branch
from
147453f
to
ab37685
Compare
|
This issue has been automatically marked as stale because it has not had activity in 60 days. Thank you for your contributions. Issues never become stale if any of the following is true:
|
thesuperzapper
changed the title
rbac.secrets value to give GET/LIST/WATCH on Secrets
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
thesuperzapper
approved these changes
May 1, 2024
There was a problem hiding this comment.
@ashokkumar-srinivas sorry for the extreme delay, but I have pushed a small cleanup to the PR in cb659ab
We will include this in the next version of the chart!
thesuperzapper
added
the
status/ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issues does your PR fix?
What does your PR do?
Currently, if a user wants to allow airflow Pods to read Secret resources, they must set
rbac.enabledto false and provision their own Role/RoleBinding.This PR adds the following values:
rbac.secrets(default:false)true, the RBAC Role used by airflow Pods will be allowed to GET/LIST/WATCH on Secret resourcesChecklist
For all Pull Requests