fix: lower maximum fee placeholder because of Paris max gas limit change

[khanti42]

Closes: #18 ,

This will be fixed in here #20

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[AndreasGassmann]

Hi @khanti42, thanks for the PR.

You are right that the constants needed to be updated. However, I'm not sure if you updated the correct one. I created a PR here where I think I updated the constant that I think has changed: #20

If we look at https://mainnet.ecadinfra.com/chains/main/blocks/head/context/constants, then it looks like the hard_gas_limit_per_block has changed to 1733333 (previoously 2600000). I also changed the taquito changelog, and it looks like they made the same change. Do you agree that this makes sense? (Also, I updated some of the constant names to be more in line with the names in the RPC response)

Regarding the failing build, my branch also failed with the same error initially. I had to bump some snap specific dependencies a few versions (not to the latest though, because then there were other errors). It has been a while since I worked with snaps last, so I think updating to the latest version has to be done with care and following all the changelogs, so I'll have to take some additional time to do that.

For now, the PR I made seems to solve the transaction issue of the snap.

Even though I didn't merge the PR, thanks for the help, I appreciate it 🙂.

[khanti42]

Hi @AndreasGassmann, this sounds great. If you also noticed that taquito did this then I think it's fair assumption to assume this works.

Regarding updating to latest snap, I fully agree with you. Updating to v1 the snap deps is already great. When moving to latest, let me know if you have any issue when doing that.

[AndreasGassmann]

@khanti42 Ok, thanks for giving it a quick review.

Also, feel free to take my changes and update your branch with them, then I can merge your PR instead of mine, since you did all the initial work of figuring this out.