Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exclude list in GA check #70

Closed
wants to merge 1 commit into from
Closed

Fix exclude list in GA check #70

wants to merge 1 commit into from

Conversation

dechamps
Copy link
Contributor

This was not updated in a59d5a1. This fixes GitHub Actions breakage.

@dechamps
Fix exclude list in GA check
087d237 
This was not updated in
a59d5a1. This
fixes GitHub Actions breakage.
@dechamps
Copy link
Contributor Author

(Hmm, I can see on this PR that the GitHub Actions workflow is not working on PRs, though it appears to work on pushes, i.e. when running directly off a branch. I think this has to do with subtle differences in actions/checkout@v4 behavior when running off a PR vs. running off a branch; see actions/checkout#426. That seems to confuse the subsequent arduino-cli lib install --git-url . command. I'm looking into it and will sent a separate PR to fix it. In the mean time, this run can be used as proof that this PR fixes the original breakage.)

@dechamps
Copy link
Contributor Author

(The unrelated PR workflow failures are addressed by #71.)

@dechamps dechamps mentioned this pull request Feb 29, 2024
Merged
@pnt325 pnt325 closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dechamps @pnt325