Only consider deployed devices when calculating uptime

[Baalmart]

Description

Only consider deployed devices when calculating uptime

Changes Made

• Only consider deployed devices when calculating uptime

Testing

• Tested locally
• Tested against staging environment
• Relevant tests passed: [List test names]

Affected Services

• Which services were modified:
  • device-registry

API Documentation Updated?

• Yes, API documentation was updated
• No, API documentation does not need updating

Additional Notes

Only consider deployed devices when calculating uptime

Summary by CodeRabbit

• New Features

  • Enhanced network status checks to focus specifically on "deployed devices."
  • Improved logging messages to provide clearer insights regarding deployed devices.

• Bug Fixes

  • Updated error handling to include visual indicators (bug emoji) for easier identification of issues.

• Documentation

  • Revised test cases to reflect changes in functionality and improve clarity regarding the status of devices.

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The pull request introduces modifications to the test suites for the checkNetworkStatus and storeReadings functionalities, focusing on the handling of "deployed devices." The import statements have been updated to reflect new module versions, and logging messages have been adjusted accordingly. The checkNetworkStatus function has also been enhanced with a new MongoDB query stage to filter for deployed devices, ensuring that the system accurately reports on their status.

Changes

File Path	Change Summary
src/device-registry/bin/jobs/test/ut_v2-check-network-status-job.js	Updated import for checkNetworkStatus, modified log messages to include "deployed devices."
src/device-registry/bin/jobs/test/ut_v2-store-readings-job.js	Transitioned to v2-store-readings-job, maintaining existing test structure and functionality.
src/device-registry/bin/jobs/v2-check-network-status-job.js	Added $match stage in MongoDB query for filtering deployed devices, updated logging messages.

Possibly related PRs

• Optimize device counting with database aggregation #3540: Modifications to the checkNetworkStatus function, directly related to the main PR's focus on logging updates.
• removing unused files and hotfixing the network status job #3598: A hotfix for the network status job, addressing similar functionality as the main PR.
• Update Offline Status for Untracked Devices #3620: Enhancements to device status management, related to the tracking of device statuses and logging updates.

Suggested reviewers

• BenjaminSsempala
• Codebmk

🎉 In the realm of code, changes take flight,
Testing the status, both day and night.
Deployed devices now take the stage,
With logs that reflect their current age.
From new to v2, the journey’s begun,
In the world of tech, we’ve surely won! 🎊

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 27.05%. Comparing base (c5732a3) to head (a45b5b7).
Report is 3 commits behind head on staging.

Files with missing lines	Patch %	Lines
...e-registry/bin/jobs/v2-check-network-status-job.js	0.00%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           staging    #3632   +/-   ##
========================================
  Coverage    27.05%   27.05%           
========================================
  Files          146      146           
  Lines        21338    21338           
  Branches       274      274           
========================================
  Hits          5772     5772           
  Misses       15566    15566           

Files with missing lines	Coverage Δ
...e-registry/bin/jobs/v2-check-network-status-job.js	44.82% <0.00%> (ø)

[github-actions]

Device registry changes in this PR available for preview here

[github-actions]

Device registry changes in this PR available for preview here