Redfish Error visibility enhancement

[jezogwza]

Describe the bug
Many errors simply ignored on redfish calls -
e.g. media injection returns 400 but we say success

Expected behavior
Errors should be bubbled up so we can define the appropriate response to errors.
It appears some of the errors can be treated as warning or simple ignored.

Currently

1. We verify the http response code and throw an error if it's not 200 or 204.
2. The redfish client likes to return non-nil errors on success, so checking err is not always reliable

[drewwalters96]

Where are these error codes reported? Is this in a virtualized environment or baremetal? All of our redfish requests are checked by http status code here, so I'm not sure how we would pass a 400 that was returned by one of our requests.

I have seen 307s in the sushy emulator that are swallowed and not returned to airshipctl. Could the same thing be happening here?

[drewwalters96]

Submitted: https://review.opendev.org/716612

[airshipbot]

Related Change #716768

Subject: Reduce the complexity of ScreenRedfishError
Link: https://review.opendev.org/716768
Status: MERGED
Owner: Ian Howell (ian.howell0@gmail.com)

Approvals

Code-Review
+1 Drew Walters
+2 Alan Meadows
+2 Matt McEuen
Verified
+2 Zuul
Workflow
+1 Alan Meadows

Last Updated: 2020-04-01 16:45:03 CDT