Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support phase apply that leverages the pruning mechanism from the kpt apply upstream #238

Closed
lb4368 opened this issue May 13, 2020 · 11 comments
Closed

Support phase apply that leverages the pruning mechanism from the kpt apply upstream #238

lb4368 opened this issue May 13, 2020 · 11 comments
Assignees
@teoyaomiqui
Labels
enhancement New feature or request priority/medium Default priority for items
Milestone
betav1

Comments

@lb4368
Copy link

lb4368 commented May 13, 2020

Problem description (if applicable)
This is a new direction for issue #8 . Discuss using kpt functionality to prune existing resources deleted from the configuration

Proposed change

Potential impacts
@lb4368 lb4368 added enhancement New feature or request triage Needs evaluation by project members labels May 13, 2020
@teoyaomiqui
Copy link
Contributor

can u assign this one to me?

@teoyaomiqui
Copy link
Contributor

related issue from kpt world: kubernetes-sigs/cli-utils#169

@jezogwza jezogwza added priority/medium Default priority for items and removed triage Needs evaluation by project members labels May 20, 2020
@jezogwza jezogwza added this to the betav1 milestone May 20, 2020
@teoyaomiqui teoyaomiqui added the wip Work in progress label May 29, 2020
@teoyaomiqui teoyaomiqui mentioned this issue Jun 16, 2020
Closed
@airshipbot airshipbot added ready for review Change related to the issue is ready for review and removed wip Work in progress labels Jun 16, 2020
@airshipbot
Copy link

airshipbot commented Jun 16, 2020 •
edited
Loading

Related Change #736010

Subject: Add more genernic Kubectl Factory interface
Link: https://review.opendev.org/736010
Status: MERGED
Owner: Kostyantyn Kalynovskyi (kkalynovskyi@mirantis.com)

Approvals

Code-Review
+2 Dmitry Ukov
+2 Ian Howell
Verified
+2 Zuul
Workflow
+1 Ian Howell

Last Updated: 2020-06-18 09:45:08 CDT

@teoyaomiqui teoyaomiqui mentioned this issue Jun 16, 2020
Closed
@airshipbot
Copy link

airshipbot commented Jun 16, 2020 •
edited
Loading

Related Change #736046

Subject: Move mock document file system to testutils
Link: https://review.opendev.org/736046
Status: MERGED
Owner: Kostyantyn Kalynovskyi (kkalynovskyi@mirantis.com)

Approvals

Code-Review
+2 Dmitry Ukov
+2 Ian Howell
+1 Ruslan Aliev
Verified
+2 Zuul
Workflow
+1 Dmitry Ukov

Last Updated: 2020-06-18 09:30:07 CDT

@teoyaomiqui teoyaomiqui mentioned this issue Jun 16, 2020
Closed
@airshipbot
Copy link

airshipbot commented Jun 16, 2020 •
edited
Loading

Related Change #736049

Subject: Add new constructor to create documents
Link: https://review.opendev.org/736049
Status: MERGED
Owner: Kostyantyn Kalynovskyi (kkalynovskyi@mirantis.com)

Approvals

Code-Review
+2 Ian Howell
+1 Ruslan Aliev
+2 Dmitry Ukov
+1 Alexey Odinokov
Verified
+2 Zuul
Workflow
+1 Dmitry Ukov

Last Updated: 2020-06-18 09:45:05 CDT

@airshipbot
Copy link

airshipbot commented Jun 16, 2020 •
edited
Loading

Related Change #736054

Subject: Integrate cli-utils applier with phases.
Link: https://review.opendev.org/736054
Status: MERGED
Owner: Kostyantyn Kalynovskyi (kkalynovskyi@mirantis.com)

Approvals

Code-Review
+2 Ian Howell
+1 Ruslan Aliev
+2 Matt McEuen
Verified
+2 Zuul
Workflow
+1 Matt McEuen

Last Updated: 2020-07-20 14:45:05 CDT

@airshipbot
Copy link

airshipbot commented Jun 16, 2020 •
edited
Loading

Related Change #736052

Subject: Add applier from cli-utils package
Link: https://review.opendev.org/736052
Status: MERGED
Owner: Kostyantyn Kalynovskyi (kkalynovskyi@mirantis.com)

Approvals

Code-Review
+2 Dmitry Ukov
+2 Ian Howell
Verified
+2 Zuul
Workflow
+1 Ian Howell

Last Updated: 2020-07-14 14:30:06 CDT

airshipbot pushed a commit that referenced this issue Jun 18, 2020
@teoyaomiqui
Add more genernic Kubectl Factory interface
cd7e99a 
Adds FakeFactory function, that allows to inject custom handlers
for HTTP and Unstructured client, which in turn enables better
testing for kubernetes api related packages

Relates-To: #276
Relates-To: #238

Change-Id: Ic27352bdc64bfccb91cc6a49afa6164e4624b1e1
Closes: #276
airshipbot pushed a commit that referenced this issue Jun 18, 2020
@teoyaomiqui
Move mock document file system to testutils
6a89670 
This commit makes mock filesystem reusable by moving it to importable
package in testutils

Change-Id: I4885480a9ef3b8c81da0058db708c32187af8e12
Relates-To: #277
Relates-To: #238
Closes: #277
airshipbot pushed a commit that referenced this issue Jun 18, 2020
@teoyaomiqui
Add new constructor to create documents
36facd3 
The change would allow to build a document object from bytes

Change-Id: I15c13a960b4e989cffa4525c85b8f32f2a51a0e1
Relates-To: #238
Relates-To: #279
Closes: #279
@airshipbot
Copy link

airshipbot commented Jul 1, 2020 •
edited
Loading

Related Change #738917

Subject: Add Append method to bundle interface
Link: https://review.opendev.org/738917
Status: MERGED
Owner: Kostyantyn Kalynovskyi (kkalynovskyi@mirantis.com)

Approvals

Code-Review
+2 Dmitry Ukov
+1 Ruslan Aliev
+2 Matt McEuen
Verified
+2 Zuul
Workflow
+1 Kostyantyn Kalynovskyi

Last Updated: 2020-07-08 12:15:03 CDT

airshipbot pushed a commit that referenced this issue Jul 8, 2020
@teoyaomiqui
Add Append method to bundle interface
edf09b0 
This method would allow us to append bundle with new documents

Change-Id: I201a2a0f2e7f707556a53495538c0f075ce6fe17
Relates-To: #238
@airshipbot
Copy link

A [Related Change](https://review.opendev.org/738917 was merged. This issue may be ready to close.

@airshipbot
Copy link

A [Related Change](https://review.opendev.org/736052 was merged. This issue may be ready to close.

airshipbot pushed a commit that referenced this issue Jul 14, 2020
@teoyaomiqui
Add applier from cli-utils package
f5cf2d3 
The commit adds applier object from cli-utils which would allow us
to wait for kubernetes objects to reach required states and support
pruning.

Integration is very similar to the one with kubectl, because backend
mechanism for reading manifests is the same. We need to write them to
temporary directory in $HOME/.airship directory, and point cli-utils
to it. It will then take care of storing what was applied to k8s cluster
for prunning and also will be capable of waiting for core resources to
reach required state by constantly polling them.

To integrate we need to create a namespace in which we will store
configmap that keeps track of what objects were applied before and enable
prunning

Relates-To: #238

Change-Id: I4c0123cc57b78bd13dbe320e0ab9f28bbed2301d
airshipbot pushed a commit that referenced this issue Jul 20, 2020
@teoyaomiqui
Integrate cli-utils applier with phases.
e4adce2 
This will also enable us to wait for kubernetes resources to reach
required state

Relates-To: #238

Change-Id: Ia2c9cebd94ca2ef5bfd9ed5830ae469e6aa6b167
@airshipbot
Copy link

A [Related Change](https://review.opendev.org/736054 was merged. This issue may be ready to close.

@eak13 eak13 removed the ready for review Change related to the issue is ready for review label Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teoyaomiqui teoyaomiqui

Labels
enhancement New feature or request priority/medium Default priority for items
Projects
None yet
Milestone
betav1
Development

No branches or pull requests
5 participants
@lb4368 @eak13 @jezogwza @teoyaomiqui @airshipbot