Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config Refactor: Refactor airshipctl config to remove clusters, users #265

Closed
lb4368 opened this issue Jun 3, 2020 · 7 comments
Closed

Config Refactor: Refactor airshipctl config to remove clusters, users #265

lb4368 opened this issue Jun 3, 2020 · 7 comments
Assignees
@ian-howell
Labels
blocked Issue is blocked by another issue or project enhancement New feature or request ready for review Change related to the issue is ready for review
Milestone
betav1

Comments

@lb4368
Copy link

lb4368 commented Jun 3, 2020

Proposed change
The refactored airshipctl config no longer will specify clusters or users. Remove clusters and users from the config.
@lb4368 lb4368 added enhancement New feature or request triage Needs evaluation by project members labels Jun 3, 2020
@lb4368 lb4368 mentioned this issue Jun 8, 2020
Closed
@jezogwza jezogwza added this to the betav1 milestone Jun 10, 2020
@jezogwza jezogwza removed the triage Needs evaluation by project members label Jun 10, 2020
@jezogwza
Copy link
Contributor

However, do we need to define a process for managing users and contexts . Removing the ability of airshipctl config to manage clusters, users make sense since we moved the dat a to the kustomize managed kubeconfig for an individual cluster.
It does leave some questions about user and context management.

@airshipbot
Copy link

airshipbot commented Jul 8, 2020 •
edited
Loading

Related Change #740098

Subject: Remove Users from the airshipctl config
Link: https://review.opendev.org/740098
Status: NEW
Owner: Ian Howell (ian.howell0@gmail.com)

Approvals

Code-Review
! None
Verified
-1 Zuul
Workflow
! None

Last Updated: 2020-07-08 15:15:09 CDT

@airshipbot airshipbot added the ready for review Change related to the issue is ready for review label Jul 8, 2020
@drewwalters96 drewwalters96 added the blocked Issue is blocked by another issue or project label Aug 26, 2020
@drewwalters96
Copy link
Contributor

Blocked by ongoing phase work

@airshipbot
Copy link

airshipbot commented Sep 18, 2020 •
edited
Loading

Related Change #752363

Subject: Refactor remote direct to use phases
Link: https://review.opendev.org/752363
Status: NEW
Owner: Kostyantyn Kalynovskyi (kkalynovskyi@mirantis.com)

Approvals

Code-Review
+1 Vladislav Kuzmin
+1 Vladimir Kozhukalov
+1 srinivasa muly
Verified
+1 Zuul
Workflow
-1 Kostyantyn Kalynovskyi

Last Updated: 2020-10-06 11:00:09 CDT

@airshipbot
Copy link

airshipbot commented Sep 22, 2020 •
edited
Loading

Related Change #753200

Subject: Stop using CurrentContextEntryPoint in remote pkg
Link: https://review.opendev.org/753200
Status: MERGED
Owner: Kostyantyn Kalynovskyi (kkalynovskyi@mirantis.com)

Approvals

Code-Review
+2 Drew Walters
+2 Matt McEuen
Verified
+2 Zuul
Workflow
+1 Matt McEuen

Last Updated: 2020-09-22 20:00:10 CDT

@airshipbot
Copy link

A [Related Change](https://review.opendev.org/753200 was merged. This issue may be ready to close.

airshipbot pushed a commit that referenced this issue Sep 23, 2020
@teoyaomiqui
Stop using CurrentContextEntryPoint in remote pkg
2b30dd0 
Note this commit doesn't refactor remote package, it is only created
to shift from using CurrentContextEntryPoint function, which would
in turn allow us to refactor config package and get rid of cluster
types in airship config.

Relates-To: #349
Relates-To: #246
Relates-To: #265

Change-Id: I1c941c8ade3497b9911fb126465aa85c25567431
@jezogwza
Copy link
Contributor

Close this issue, and for any remnants of cleanup will open new bugs when we see them or experience them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ian-howell ian-howell

Labels
blocked Issue is blocked by another issue or project enhancement New feature or request ready for review Change related to the issue is ready for review
Projects
None yet
Milestone
betav1
Development

No branches or pull requests
5 participants
@lb4368 @jezogwza @drewwalters96 @ian-howell @airshipbot