Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify the k8scontrol function to deploy Calico via function #303

Closed
eak13 opened this issue Jul 20, 2020 · 5 comments
Closed

Modify the k8scontrol function to deploy Calico via function #303

eak13 opened this issue Jul 20, 2020 · 5 comments
Assignees
@sreejithpunnapuzha
Labels
enhancement New feature or request ready for review Change related to the issue is ready for review
Milestone
betav1

Comments

@eak13
Copy link

eak13 commented Jul 20, 2020

Proposed change
As a deployment engineer, I want to be able to deploy the Calico CNI in a consistent & declarative fashion by leveraging the Calico function defined in manifests/function/calico.

Update the k8scontrol/controlplane.yaml to no longer apply the internet version of Calico & instead leverage the Calico function.

This issue is dependent on #302 which creates the Calico function
@eak13 eak13 added enhancement New feature or request triage Needs evaluation by project members labels Jul 20, 2020
@jezogwza jezogwza removed the triage Needs evaluation by project members label Jul 22, 2020
@jezogwza jezogwza added this to the betav1 milestone Jul 22, 2020
@sreejithpunnapuzha sreejithpunnapuzha self-assigned this Jul 22, 2020
@airshipbot airshipbot added the ready for review Change related to the issue is ready for review label Jul 27, 2020
@airshipbot
Copy link

airshipbot commented Jul 27, 2020 •
edited
Loading

Related Change #743402

Subject: Added function to support deployment of calico CNI
Link: https://review.opendev.org/743402
Status: NEW
Owner: Sirajudeen (sirajudeen.yasin@gmail.com)

Approvals

Code-Review
-1 Sirajudeen
Verified
! None
Workflow
-1 Sirajudeen

Last Updated: 2020-07-28 16:15:05 CDT

@airshipbot
Copy link

airshipbot commented Aug 11, 2020 •
edited
Loading

Related Change #743763

Subject: Deploy calico via function.
Link: https://review.opendev.org/743763
Status: MERGED
Owner: Sirajudeen (sirajudeen.yasin@gmail.com)

Approvals

Code-Review
+1 Matt McEuen
+2 Kostyantyn Kalynovskyi
+1 Ruslan Aliev
+1 Arijit Bose
+2 Dmitry Ukov
Verified
+2 Zuul
Workflow
+1 Dmitry Ukov

Last Updated: 2020-08-26 10:00:07 CDT

@airshipbot airshipbot added wip Work in progress ready for review Change related to the issue is ready for review and removed ready for review Change related to the issue is ready for review wip Work in progress labels Aug 25, 2020
airshipbot pushed a commit that referenced this issue Aug 26, 2020
@sirajyasin
Deploy calico via function.
b2c0590 
* Deploy Calico to ephemeral and target via function
* Removed the condition to check node ready status in
  25_deploy_ephemeral_node.sh and 30_deploy_controlplane.sh.
  As calico is applied at a later stage, relaxed the dependency to wait
for node ready status.
* updated compoiste/infra for calico manifest

Change-Id: Id582aec3ca402eac02d9baa2305b562c410c1bea
Relates-To: #303
Relates-To: #304
@airshipbot
Copy link

A [Related Change](https://review.opendev.org/743763 was merged. This issue may be ready to close.

@sirajyasin
Copy link
Contributor

The related PS (https://review.opendev.org/743763) is merged. This issue can be closed now.

@sreejithpunnapuzha
Copy link
Member

closing this as ps is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sreejithpunnapuzha sreejithpunnapuzha

Labels
enhancement New feature or request ready for review Change related to the issue is ready for review
Projects
None yet
Milestone
betav1
Development

No branches or pull requests
5 participants
@eak13 @jezogwza @sirajyasin @sreejithpunnapuzha @airshipbot