Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce "Plan Describe" Command #394

Closed
lb4368 opened this issue Nov 6, 2020 · 8 comments
Closed

Introduce "Plan Describe" Command #394

lb4368 opened this issue Nov 6, 2020 · 8 comments
Assignees
Labels
enhancement New feature or request priority/low Items that are considered non-critical for functionality, such as quality of life improvements ready for review Change related to the issue is ready for review size m
Milestone

Comments

@lb4368
Copy link

lb4368 commented Nov 6, 2020

Proposed change
Add an 'airshipctl plan describe' command that take a phase plan name/namespace and return information that would give an operator insight into what is contained within the phase plan.

This issue is similar to #393 but is for phase plans rather than a single phase.

The command should return:

1. A description of the phase plan. This would require a description field be added to the Phase Plan document that could be populated by the phase plan creator to provide useful information about the plan to a user.
2. A list of the phases that are contained within the phase plan.  The output of the phase list should be grouped by phase groups specified within the plan.
@lb4368 lb4368 added enhancement New feature or request triage Needs evaluation by project members labels Nov 6, 2020
@lb4368 lb4368 added this to the v2.0 milestone Nov 6, 2020
@jezogwza jezogwza removed the triage Needs evaluation by project members label Nov 11, 2020
@muly
Copy link
Contributor

muly commented Nov 24, 2020

please assign this to me

@lb4368
Copy link
Author

lb4368 commented Dec 2, 2020

Per 12/1/20 design call, this command should be implemented by adding a yaml output option to the airshipctl plan list command from #385. The command will output the phase plan artifacts in yaml output rather than tabular output.

Example:
airshipctl plan list -o yaml

@niharikabhavaraju
Copy link
Contributor

please assign it to me

@eak13
Copy link

eak13 commented Feb 3, 2021

@niharikabhavaraju added you as well.

@eak13 eak13 unassigned muly Feb 3, 2021
@eak13 eak13 added the size m label Feb 23, 2021
@airshipbot airshipbot added the ready for review Change related to the issue is ready for review label Feb 23, 2021
@airshipbot
Copy link

airshipbot commented Feb 23, 2021

Related Change #771286

Subject: [#394] plan list -o yaml changes
Link: https://review.opendev.org/c/airship/airshipctl/+/771286
Status: MERGED
Owner: srinivasa muly (msrinivasareddy@gmail.com)

Approvals

Code-Review
+1 Bijaya Sharma
+2 Kostyantyn Kalynovskyi
+2 Matt McEuen
Verified
+1 ATT Airship2.0 CI
+2 Zuul
Workflow
+1 Matt McEuen

Last Updated: 2021-04-29 20:19:01 CDT

@lb4368 lb4368 added the priority/low Items that are considered non-critical for functionality, such as quality of life improvements label Mar 3, 2021
@lb4368 lb4368 modified the milestones: v2.0, v2.1 Mar 18, 2021
@airshipbot
Copy link

airshipbot commented Mar 23, 2021

Related Change #782522

Subject: [#394] plan list -o yaml changes
Link: https://review.opendev.org/c/airship/airshipctl/+/782522
Status: ABANDONED
Owner: Niharika Bhavaraju (niha.twinkle@gmail.com)

Approvals

Code-Review
! None
Verified
-1 ATT Airship2.0 CI
Workflow
! None

Last Updated: 2021-03-23 10:18:56 CDT

airshipbot pushed a commit that referenced this issue Apr 30, 2021
Added yaml output flag to show plan list in yaml format

Relates-To: #394
Co-authored By: Niharika Bhavaraju<niha.twinkle@gmail.com>
Change-Id: I8bed077573eb79783cfc77e4ebf82c819f41d125
@niharikabhavaraju
Copy link
Contributor

related commit https://review.opendev.org/c/airship/airshipctl/+/771286 has been merged. This issue can be closed.

@lb4368
Copy link
Author

lb4368 commented May 7, 2021

Closed per patchset merge

@lb4368 lb4368 closed this as completed May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority/low Items that are considered non-critical for functionality, such as quality of life improvements ready for review Change related to the issue is ready for review size m
Projects
None yet
Development

No branches or pull requests

6 participants