Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow some additional steps (including extracting kubeconfig and untainting) in phase run #580

Closed
ratnopamc opened this issue Jun 14, 2021 · 2 comments
Assignees
Labels
2-Manifests Relates to manifest/document set related issues 4-CI/CD Relates to issues with Zuul & gating enhancement New feature or request priority/medium Default priority for items size m
Milestone

Comments

@ratnopamc
Copy link
Contributor

Problem description (if applicable)

For infrastructure providers such as capd, the airshipctl phase run involves doing some additional steps in between 2 phases. For instance, following operation is performed between phase controlplane-ephemeral and initinfra-networking-target .

airshipctl cluster get-kubeconfig > ~/.airship/kubeconfig-tmp
mv ~/.airship/kubeconfig-tmp "${KUBECONFIG}"

Additionally untainting of control plane nodes, setting of contexts (ephemeral and target clusters) are also performed outside of any phase run.
Currently there's no phase available to perform these steps. Once these phases are available, they can be included and executed as part of a phasePlan.

For a description of the workflow(for capd) can be found in https://github.com/airshipit/airshipctl/blob/master/docs/source/providers/cluster_api_docker.md#deploy-control-plane-and-workers . The scripts can be referenced in https://github.com/airshipit/airshipctl/tree/master/tools/deployment/provider_common directory.

Proposed change
Create phases and executors to execute additional steps that need to be performed for deployment of docker and cloud providers(capz, capg, capo).

Potential impacts
Potential security or performance related impacts.

@ratnopamc ratnopamc added enhancement New feature or request triage Needs evaluation by project members labels Jun 14, 2021
@ratnopamc ratnopamc changed the title Allow extracting kubeconfig and other steps in phase run Allow some additional steps (including extracting kubeconfig and untainting) in phase run Jun 14, 2021
@jezogwza jezogwza added this to the v2.2 milestone Jun 16, 2021
@jezogwza jezogwza added 2-Manifests Relates to manifest/document set related issues 4-CI/CD Relates to issues with Zuul & gating priority/critical Items critical to be implemented, usually by the next release priority/medium Default priority for items and removed triage Needs evaluation by project members priority/critical Items critical to be implemented, usually by the next release labels Jun 16, 2021
@lb4368 lb4368 added the size m label Jun 24, 2021
@jezogwza jezogwza modified the milestones: v2.2, v2.1 Jul 7, 2021
airshipbot pushed a commit that referenced this issue Sep 16, 2021
This PS introduces phase plan for CAPD provider
 * Adds phase to merge kubeconfig
 * Patches type/gating plan to use capd phase plan
 * Patches cluster_map and executor to work with "default" namespace
 * Fixes CAPD zuul failures

Relates-To: #564
Relates-To: #580
Relates-To: #587
Change-Id: I5007970c907bc87dccf6dd9fcb052afc1b5c13f7
@ratnopamc
Copy link
Contributor Author

This issue can be closed. Fix for this issue has been merged.

@eak13
Copy link

eak13 commented Oct 27, 2021

Code has been merged. Closing.

@eak13 eak13 closed this as completed Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2-Manifests Relates to manifest/document set related issues 4-CI/CD Relates to issues with Zuul & gating enhancement New feature or request priority/medium Default priority for items size m
Projects
None yet
Development

No branches or pull requests

4 participants