Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement airshipctl version #630

Closed
ian-howell opened this issue Sep 3, 2021 · 3 comments
Closed

Implement airshipctl version #630

ian-howell opened this issue Sep 3, 2021 · 3 comments
Assignees
@sreejithpunnapuzha
Labels
design needed New Design or Redesign required enhancement New feature or request priority/medium Default priority for items
Milestone
v2.1

Comments

@ian-howell
Copy link
Contributor

ian-howell commented Sep 3, 2021 •
edited
Loading

Problem description (if applicable)
airshipctl version currently reports that it is v0.1.0, no matter when or how the binary was created.

Proposed change
Borrow from a more mature project such as helm or kustomize so that we can display the tag or git sha of the built binary.
@ian-howell ian-howell added enhancement New feature or request triage Needs evaluation by project members labels Sep 3, 2021
@lb4368 lb4368 added priority/medium Default priority for items and removed triage Needs evaluation by project members labels Sep 8, 2021
@lb4368 lb4368 added this to the v2.2 milestone Sep 8, 2021
@lb4368 lb4368 added the design needed New Design or Redesign required label Sep 8, 2021
@sreejithpunnapuzha sreejithpunnapuzha self-assigned this Sep 8, 2021
@ian-howell
Copy link
Contributor Author

Here's what I was talking about with linker flags on the Flight Plan call: https://www.digitalocean.com/community/tutorials/using-ldflags-to-set-version-information-for-go-applications

@sreejithpunnapuzha
Copy link
Member

Commit https://review.opendev.org/c/airship/airshipctl/+/810128 Pushed with the changes.

airshipbot pushed a commit that referenced this issue Sep 21, 2021
@sreejithpunnapuzha
Add git commit hash and build date to version
0620deb 
This commit adds git commit hash and build date to airshipctl version
command.

Relates-To: #630

Signed-off-by: Sreejith Punnapuzha <Sreejith.Punnapuzha@outlook.com>
Change-Id: Ic27db40cf80153cb5d3af3accacd33e85d36010d
@sreejithpunnapuzha
Copy link
Member

Commit https://review.opendev.org/c/airship/airshipctl/+/810128 is merged. hence closing this issue.

@eak13 eak13 modified the milestones: v2.2, v2.1 Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sreejithpunnapuzha sreejithpunnapuzha

Labels
design needed New Design or Redesign required enhancement New feature or request priority/medium Default priority for items
Projects
None yet
Milestone
v2.1
Development

No branches or pull requests
4 participants
@lb4368 @eak13 @ian-howell @sreejithpunnapuzha