Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple versions of clusterctl #650

Closed
lb4368 opened this issue Oct 4, 2021 · 5 comments
Closed

Support multiple versions of clusterctl #650

lb4368 opened this issue Oct 4, 2021 · 5 comments
Assignees
@raliev12
Labels
enhancement New feature or request priority/critical Items critical to be implemented, usually by the next release
Milestone
v2.1

Comments

@lb4368
Copy link

lb4368 commented Oct 4, 2021 •
edited
Loading

Problem description (if applicable)
In order to support multiple CAPI providers (capm3, capz, capo, etc) and their associated release schedules, airshipctl needs to support multiple versions of CAPI concurrently. The current clusterctl KRM function only supports a single clusterctl CLI version.

Proposed change

  • Provide support within airshipctl for multiple versions of clusterctl
  • Provide a mechanism to determine the proper version of clusterctl to use for a deployment

See design discussion here: https://hackmd.io/QiEksO4fRk-MnBjwBFaAkQ#UPD-Alexey-O
@lb4368 lb4368 added enhancement New feature or request triage Needs evaluation by project members labels Oct 4, 2021
@shon-phand
Copy link
Contributor

Please assign this to me, I am working on it.

@mattmceuen mattmceuen added this to the v2.1 milestone Oct 6, 2021
@mattmceuen mattmceuen added priority/critical Items critical to be implemented, usually by the next release and removed triage Needs evaluation by project members labels Oct 6, 2021
@mattmceuen
Copy link
Contributor

There have been discussions around keeping the latest versions as simply "clusterctl", and only using version numbers for exception cases, when a CAPI provider needs to use an old version. Just want to make sure, @raliev12 are you and Alexey aligned to this?

@raliev12
Copy link
Contributor

raliev12 commented Oct 6, 2021

@mattmceuen that is completely correct, I prepared a PS which complies with that concept past week already - https://review.opendev.org/c/airship/airshipctl/+/812183

@aodinokov
Copy link

only using version numbers for exception cases, when a CAPI provider needs to use an old version

@mattmceuen yes, we're aligned.. the patchset from Ruslan makes it work that way

@lb4368 lb4368 assigned raliev12 and unassigned shon-phand Oct 6, 2021
airshipbot pushed a commit that referenced this issue Oct 8, 2021
@raliev12
Add clusterctl v0.3.x KRM function
597bf0f 
This KRM function will contain clusterctl binary with version
0.3.x for backward compatibility while the main one will move
forward with 0.4.x releases.

Change-Id: Iba167be074c07a20701ed45c4b2ccf38ddb2185a
Signed-off-by: Ruslan Aliev <raliev@mirantis.com>
Related-To: #647
Related-To: #642
Relates-To: #650
@lb4368
Copy link
Author

lb4368 commented Oct 13, 2021

PS merged. Closing

@lb4368 lb4368 closed this as completed Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raliev12 raliev12

Labels
enhancement New feature or request priority/critical Items critical to be implemented, usually by the next release
Projects
None yet
Milestone
v2.1
Development

No branches or pull requests
5 participants
@lb4368 @aodinokov @mattmceuen @raliev12 @shon-phand