Remove six library #1058
Remove six library #1058
Conversation
|
Thanks for the contribution @Leenkiz. Looks like you've got conflicts, can you please merge master into your branch, resolve the conflicts, and push.. again. We need this to be able to run the CI checks and merge. Thanks! |
|
Thanks for this @Leenkiz the conflicts mean that the upstream has new changes that your local copy doesn't have so you need to run git fetch upstream and |
|
Thanks @Leenkiz ,one more change, import socketserver will solve your issue as socketserver is used but not defined |
|
@dorothykiz1 @LucyJimenez, looks like there are test failures in appveyor that are not showing in GitHub actions. We should have a look and see why is this happening. Do you mind creating an issue, linking to both the appveyor and GitHub actions builds in this PR (not the PR itself, since it'll get lost when the test is fixed), and then have a look and find what's the problem. In the CI logs you should find the commands that have been executed in both systems. You should be able to implement the bug causing the test failure locally, run both commands, and see one failing and the other passing. |
I have created issue #1060 to reference this |
asv/commands/preview.py
Outdated
| @@ -84,9 +83,9 @@ def run_from_conf_args(cls, conf, args): | |||
| def run(cls, conf, port=0, browser=False): | |||
| os.chdir(conf.html_dir) | |||
|
|
|||
| class Handler(SimpleHTTPServer.SimpleHTTPRequestHandler): | |||
| class Handler(http.server.SimpleHTTPRequestHandler): | |||
There was a problem hiding this comment.
Looks like http.server is not defined. We should import it.
@dorothykiz1 looks like we don't have tests for preview. It'd be good to create an issue for it. And also, if you want to have a look at other commands that are not tested, that would be very helpful. Not having any test for a command means that like here, even a bug like this one can be added unnoticed (this would fail as soon as the command is executed, for all cases).
There was a problem hiding this comment.
Thanks @datapythonista i noticed locally the test cases were being skipped for the GitHub actions CI, I will take a look at this
|
Thanks @Leenkiz, nice clean up. I reverted the part that was tricky, so we could merge the other changes. But feel free to continue in a new PR if you want. |
No description provided.