Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flake8 errors in some files in asv/ directory #1067

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

dorothykiz1
Copy link
Contributor

This PR fixes all flake8 errors in ;

  • asv/template/benchmarks/benchmarks.py
  • asv/template/benchmarks/init.py
  • asv/runner.py
  • asv/results.py
  • asv/machine.py
  • asv/graph.py
  • asv/environment.py
  • asv/benchmarks.py

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dorothykiz1, really nice. Will merge on green.

@datapythonista datapythonista reopened this Mar 1, 2022
@datapythonista datapythonista merged commit 7d83f4a into airspeed-velocity:master Mar 1, 2022
@datapythonista
Copy link
Member

Thanks @dorothykiz1, something that we could do now that flake8 errors are in 4 main directories, is to update setup.cfg to exclude those. Not sure about test, how much it's being validated there, but for the rest it can make sense. So, when an issue is closed, is quick to just delete one line from the excludes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants