Fix Flake8 violations for files in the test/test_web.py #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2af36bf.
…o airspeed-velocity-master
test/test_web.py
Outdated
| @@ -23,7 +20,7 @@ | |||
| pass | |||
|
|
|||
| from . import tools | |||
| from .tools import browser, get_with_retry, WAIT_TIME, locked_cache_dir, WIN | |||
| from .tools import browser, get_with_retry, WAIT_TIME, locked_cache_dir, WIN # noqa F401 '.tools.browser' imported but unused. The fixture 'browser' is necessary for several functions | |||
There was a problem hiding this comment.
Do you mind moving the fixture of fixtures to conftest in a separate PR before merging this, so we don't need to have this noqa.
CC: @dorothykiz1
There was a problem hiding this comment.
I worked on this. Refer to #1114 PR
@datapythonista |
|
This has conflicts, can you resolve them pelase? |
test/test_web.py
Outdated
Comment on lines
180
to
181
| regression_2 = browser.find_element_by_link_text('params_examples.track_find_test(2)') # noqa F841 assigned to but never used, needed to check the link | ||
| bad_hash_link = browser.find_element_by_link_text(bad_commit_hash[:8]) # noqa F841 assigned to but never used, needed to check the link |
There was a problem hiding this comment.
Don't assign to a variable if the result is not used.
test/test_web.py
Outdated
Comment on lines
259
to
260
| popover = browser.find_element_by_css_selector('div.popover-content') # noqa F841 assigned to but never used, needed to check an element | ||
| flotplot = browser.find_element_by_css_selector('canvas.flot-base') # noqa F841 assigned to but never used, needed to check an element |
|
@datapythonista I included the last comments and resolved the conflicts. The PR is ready for review. Thanks a lot! |
|
Thanks @LucyJimenez, very nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #1042
Fix pep8 issues on
test_web.pyNote: the fixture issues will be solved in another PR.