Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: test pypy #1111

Merged
merged 3 commits into from
Mar 8, 2022
Merged

Conversation

fangchenli
Copy link
Contributor

@fangchenli fangchenli commented Mar 7, 2022

Closes #1073 #1085

Comment on lines -16 to -17
pytest-faulthandler; platform_python_implementation != "PyPy"
pytest-faulthandler<2.0; platform_python_implementation == "PyPy"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pytest-faulthandler is included in pytest>=5.0

requirements-dev.txt Outdated Show resolved Hide resolved
@@ -586,7 +586,7 @@ def test_pypy_virtualenv(tmpdir):
for env in environments:
env.create()
output = env.run(['-c', 'import sys; print(sys.pypy_version_info)'])
assert output.startswith(str("(major="))
assert "(major=" in output
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was this PR for this error: #1002 I was waiting to have pypy tests in the CI to merge, happy to get merge there now that this has been tested, or to get the fix here.

CC: @QuLogic

@datapythonista datapythonista merged commit 798de2e into airspeed-velocity:master Mar 8, 2022
@datapythonista
Copy link
Member

Thanks @fangchenli, really nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include a CI run with PyPy
2 participants