Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move test_benchmarks.py and test_workflow.py fixtures to conftest.py file #1121

Merged

Conversation

dorothykiz1
Copy link
Contributor

xref #1030

@datapythonista
Copy link
Member

Looks like one of the fixtures you're creating in the new file, is not the one you're deleting from the other file.

@dorothykiz1
Copy link
Contributor Author

Looks like one of the fixtures you're creating in the new file, is not the one you're deleting from the other file.

Thanks, @datapythonista for your review, seen my mistake and have removed and resolved it, the other fixture in test/test_publish.py already exists in conftest.py ,so i didn't add it

@dorothykiz1
Copy link
Contributor Author

@datapythonista this PR is ready for your review

@datapythonista datapythonista merged commit cf3b171 into airspeed-velocity:master Mar 9, 2022
@datapythonista
Copy link
Member

Thanks @dorothykiz1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants