Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect_regression: value 'after' regression is the minimum, not next one #744

Merged
merged 1 commit into from
Sep 21, 2018

Conversation

pv
Copy link
Collaborator

@pv pv commented Sep 21, 2018

Change the value 'after' a regression to be the minimum of values
following the upward step.

Previously, it was the value immediately after the upward step.
However, typically the important question is how much worse the
situation is, after taking into account any commits trying to rectify
the problem.

Using 'minimum' instead of 'next' value enables better ranking of how
important regressions are in practice.

That the code becomes also simpler is probably a sign that this is the
right thing.

Change the value 'after' a regression to be the minimum of values
following the upward step.

Previously, it was the value immediately after the upward step.
However, typically the important question is how much worse the
situation is, after taking into account any commits trying to rectify
the problem.

Using 'minimum' instead of 'next' value enables better ranking of how
important regressions are in practice.

That the code becomes also simpler is probably a sign that this is the
right thing.
@pv pv merged commit 8ee7ab2 into airspeed-velocity:master Sep 21, 2018
@pv pv deleted the regression-sizes branch October 21, 2018 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant